Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing from upstream odoo/runbot (18.0-min-max-version-xdo) #819

Open
wants to merge 37 commits into
base: 18.0-min-max-version-xdo
Choose a base branch
from

Conversation

bt-admin
Copy link

bt_gitbot

Xavier-Do and others added 30 commits January 2, 2025 10:03
Adds the missing field `config_data` to trigger's form view.
`target="new"` had the very confusing behavior of updating the same tab
within the same browser context (tab).
The commit replaces all `target="new"` occurences with `target="_blank"`
within the runbot templates.

See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#target
The previous fix in c9e8e13 was not enough, while preventing a crash
of the view, the view was empty.
bundle_id is not computed anymore
When the reference build for some build is not done yet a message is
logged with a link to the referenced build, however due to a typo in the
message the markdown was badly formatted.
- Add dropdown-toggle to the github tool button so that it doesn't
  appear as if a button should be following it.
- Add default btn classes to category icons, the button would otherwise
  be displayed as just an icon.
- Add a gap between the two toolbars.
- Add d-empty-none in case we have no category to display to remove the
  useless gap.
Allows searching branch through pr url or full branch name.
Also fixes a crash when searching invalid values.
While it's useful to have a clickable link to the fixing pull request
on the runbot error list, we cannot display the entire url as it takes
too much space. So a static text `View PR` is used.

As this static text is of limited use, this commit adds a new widget
that displays a shortened URL for the github pull request only showing
the repo and the PR number.
Supports the format (?owner)/repo#id in the `_search_dname` method.
`record._cr` is being deprecated in odoo/odoo#193636 this commit
replaces the old `._cr` with `env.cr`.
Exceptions and their followups are managed by their managers, this will
prevent having to create a custom filter to get our own exceptions.
The current qualifying implementation is based solely on error content.
With this commit the fields on which the regular expression will apply
can be choosen with checkboxes. It defaults to the `content` field.
Removes auto tags from a build if the build's branches match the build
error's fixing branch.
fix typos, and grammatical mistakes
fix URL to change the master password.
The row_number window function is quite unoptimized as it requires
reading the whole table.
Using lateral join and / or distinct makes better use of existing
indexes.
Looks like bu.database_ids[1:].sorted('name') was breaking the prefech
set leading to one query per build. Fiwing it by sorting without slicing
the ignoring the first record.

~230 ms improvement over 1.7 second
The corresponding fields are stored on the build,
no need to read the params.
This allows to configure a custom trigger to use the base commits.
This can be usefull to test a config on a branch that has some changes
to ensure it works proprely.
- Fix the model on parse_logs action window.
- Add a server action on build to open its errors
- Fix a bad indentation
This commit adds a `common_qualifiers` field on build error. Its purpose
is mainly to find similary qualified errors and similary qualified error
contents. This field is computed by finding qualifiers in common in all
the qualifiers of the error contents linked to the error.

A new `unique_qualifiers` is also added for the same kind of puprpose.
This field is computed by finding non contradictory qualifiers of the
linked error contents.

The fields can be used in 4 tabs added on the build error form.
Xavier-Do and others added 3 commits February 26, 2025 10:14
Makes it possible to filter on host on the load_info view.
Monitoring was also adapted to have links to filtered load_info page.
When adding an internal link in discord or other platform, a preview of
the login page is given. This is not usefull nor elegant.

This commit proposes to remove the logo and give useful information
instead
Williambraecky and others added 3 commits March 3, 2025 14:26
Just as useful as tracking the test-tags itself.
Before this commit:
The only way to have details on the builds was to use the embed
one2many widget in the build error form view.
This was pretty inconvenient for complicated search as there is no
way to filter the records or group them

After this commit:
A list view now exist for the model `runbot.build.error.link`
allowing to filter and group on convenient fields.
This list view can be accessed on the runbot build error through
a smart button
@Xavier-Do Xavier-Do force-pushed the 18.0-min-max-version-xdo branch from c3220bd to 6ec1d4e Compare March 4, 2025 10:27
@Xavier-Do Xavier-Do force-pushed the 18.0-min-max-version-xdo branch from 6ec1d4e to 9377df5 Compare March 4, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants