forked from odoo/runbot
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing from upstream odoo/runbot (17.0-qualify-other-fields-moc) #803
Open
bt-admin
wants to merge
15
commits into
brain-tec:17.0-qualify-other-fields-moc
Choose a base branch
from
odoo:17.0-qualify-other-fields-moc
base: 17.0-qualify-other-fields-moc
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Syncing from upstream odoo/runbot (17.0-qualify-other-fields-moc) #803
bt-admin
wants to merge
15
commits into
brain-tec:17.0-qualify-other-fields-moc
from
odoo:17.0-qualify-other-fields-moc
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the missing field `config_data` to trigger's form view.
`target="new"` had the very confusing behavior of updating the same tab within the same browser context (tab). The commit replaces all `target="new"` occurences with `target="_blank"` within the runbot templates. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#target
The previous fix in c9e8e13 was not enough, while preventing a crash of the view, the view was empty.
bundle_id is not computed anymore
When the reference build for some build is not done yet a message is logged with a link to the referenced build, however due to a typo in the message the markdown was badly formatted.
- Add dropdown-toggle to the github tool button so that it doesn't appear as if a button should be following it. - Add default btn classes to category icons, the button would otherwise be displayed as just an icon. - Add a gap between the two toolbars. - Add d-empty-none in case we have no category to display to remove the useless gap.
Allows searching branch through pr url or full branch name. Also fixes a crash when searching invalid values.
While it's useful to have a clickable link to the fixing pull request on the runbot error list, we cannot display the entire url as it takes too much space. So a static text `View PR` is used. As this static text is of limited use, this commit adds a new widget that displays a shortened URL for the github pull request only showing the repo and the PR number.
Supports the format (?owner)/repo#id in the `_search_dname` method.
`record._cr` is being deprecated in odoo/odoo#193636 this commit replaces the old `._cr` with `env.cr`.
Exceptions and their followups are managed by their managers, this will prevent having to create a custom filter to get our own exceptions.
The current qualifying implementation is based solely on error content. With this commit the fields on which the regular expression will apply can be choosen with checkboxes. It defaults to the `content` field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot