Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing from upstream OCA/queue (14.0) #400

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Syncing from upstream OCA/queue (14.0) #400

merged 3 commits into from
Sep 6, 2024

Conversation

bt-admin
Copy link

@bt-admin bt-admin commented Sep 6, 2024

bt_gitbot

simahawk and others added 3 commits September 3, 2024 09:54
Current situation:

* multiple keys for no good reason
* half baked: not all of them used everywhere
* no centralization
* poor naming

With this change we'll have:

* 1 and only one key to disable via ctx: ``queue_job__no_delay``
* 1 and only one key to disable via os env: ``QUEUE_JOB__NO_DELAY``
* backward compatibility with deprecation for old keys
Signed-off-by simahawk
@bt-admin bt-admin added the 14.0 label Sep 6, 2024
@bt-admin bt-admin merged commit 866869c into brain-tec:14.0 Sep 6, 2024
4 checks passed
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.68%. Comparing base (30e57e6) to head (ee55b99).
Report is 88 commits behind head on 14.0.

Files with missing lines Patch % Lines
queue_job/utils.py 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             14.0     #400      +/-   ##
==========================================
- Coverage   83.70%   83.68%   -0.02%     
==========================================
  Files          87       88       +1     
  Lines        4609     4622      +13     
  Branches      583      587       +4     
==========================================
+ Hits         3858     3868      +10     
- Misses        662      664       +2     
- Partials       89       90       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants