Syncing from upstream OCA/product-variant (15.0) #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[15.0][UPD] Copier update
With a non automatic reference mask that has a code prefix, when that reference mask is recomputed, we could be repeating the prefix without noticing it. For instance, when we change an product.attribute name and that triggers all the default codes recomputations. In a product template with variants (i.e.: Conference Chair) - You'll have a reference mask ([Legs]) - Add a prefix: cc --> The prefix is duplicated in the reference mask: cccc[Legs] - Now you can delete de prefix manually from the mask and the resulting mask will be right: cc[Legs] - Now change the name of the attribute Legs to something else. --> The mask computation is retriggered and we get a duplicated prefix again cccc[Legs]. An extra issue would be that the mask isn't recomputed with the new attribute name, although that would need some extra work. TT48322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot