Syncing from upstream OCA/partner-contact (18.0) #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really I'm just renaming partner_contact_base. The new name is more self-explanatory.
[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10
- fax field removed from res.partner - 2to3 on all py files - add contributor and update README - use hasclass in place of @Class in xpath expr - improve tests [FIX] typo and clean README
Also adopt the module
Code improvements
Currently translated at 100.0% (3 of 3 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_fax Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_fax/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-16.0/partner-contact-16.0-partner_fax Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_fax/
Currently translated at 100.0% (3 of 3 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_fax Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_fax/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-18.0/partner-contact-18.0-partner_contact_personal_information_page Translate-URL: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-partner_contact_personal_information_page/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-18.0/partner-contact-18.0-partner_fax Translate-URL: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-partner_fax/
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 18.0 #1336 +/- ##
==========================================
+ Coverage 95.77% 95.78% +0.01%
==========================================
Files 108 111 +3
Lines 1868 1874 +6
Branches 143 143
==========================================
+ Hits 1789 1795 +6
Misses 57 57
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot