forked from OCA/commission
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing from upstream OCA/commission (16.0) #465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (13 of 13 strings) Translation: commission-14.0/commission-14.0-sale_commission_agent_restrict Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_agent_restrict/it/
Currently translated at 100.0% (14 of 14 strings) Translation: commission-14.0/commission-14.0-sale_commission_agent_restrict Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_agent_restrict/it/
Fix that ended up involving a significant refactor of the entire module. The goal was mostly to keep the same functionality but also keep the security rule about hiding private addresses for accounts that are not agents. The commit adds a new OCA dependency; there's some code cleanup and refactoring as well, and many more tests.
Currently translated at 100.0% (14 of 14 strings) Translation: commission-14.0/commission-14.0-sale_commission_agent_restrict Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_agent_restrict/it/
Quick fix for a bug that meant an agent could not create any contact because the form would pre-populate the value of payment terms.
Remove web_domain_field dependency: it is no more used since 519bffc, and deprecated in `16.0`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot