Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing from upstream OCA/bank-statement-import (16.0) #593

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

bt-admin
Copy link

bt_gitbot

…parser header

When importing an Excel file with a header and the field header_lines_skip_count is set to its default value (0), the header is retrieved using the -1 index (the last row).
complementary to commit 13285ab
…tune the UI

Before this commit, the parse_header function was unused. It is now utilized to reduce redundant code and improve maintainability.
Additionally, UI adjustments have been made for better usability and clarity.
Signed-off-by pedrobaeza
@bt-admin bt-admin added the 16.0 label Jan 15, 2025
@bt-admin bt-admin merged commit f6bbba8 into brain-tec:16.0 Jan 15, 2025
4 checks passed
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.31%. Comparing base (2298d49) to head (f176a7b).
Report is 84 commits behind head on 16.0.

Files with missing lines Patch % Lines
...le/models/account_statement_import_sheet_parser.py 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             16.0     #593      +/-   ##
==========================================
+ Coverage   84.01%   84.31%   +0.29%     
==========================================
  Files          95       95              
  Lines        3329     3321       -8     
  Branches      385      386       +1     
==========================================
+ Hits         2797     2800       +3     
+ Misses        398      386      -12     
- Partials      134      135       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants