Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing from upstream OCA/bank-statement-import (16.0) #589

Merged
merged 6 commits into from
Dec 25, 2024

Conversation

bt-admin
Copy link

bt_gitbot

remytms and others added 6 commits October 20, 2024 13:20
The field acc_number in the database is not sanitized by default.

This leads to account_bank_statement_line with an empty partner_id
because the check done in _statement_line_import_update_hook()
uses the sanitized_acc_number instead of the acc_number.

For a right comparison the sanitized version of the acc_number should be
put in the speeddict.
Signed-off-by pedrobaeza
Signed-off-by pedrobaeza
@bt-admin bt-admin added the 16.0 label Dec 25, 2024
@bt-admin bt-admin merged commit ddbc1fe into brain-tec:16.0 Dec 25, 2024
4 checks passed
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 61.02236% with 122 lines in your changes missing coverage. Please review.

Project coverage is 83.98%. Comparing base (805ba5a) to head (5e151fc).
Report is 175 commits behind head on 16.0.

Files with missing lines Patch % Lines
...e_ofx/models/online_bank_statement_provider_ofx.py 29.05% 82 Missing and 1 partial ⚠️
...ocardless/models/online_bank_statement_provider.py 25.64% 28 Missing and 1 partial ⚠️
...e_ofx/wizards/online_bank_statement_pull_wizard.py 69.23% 4 Missing ⚠️
...e/models/account_statement_import_sheet_mapping.py 71.42% 1 Missing and 1 partial ⚠️
..._statement_import_online/models/account_journal.py 50.00% 1 Missing ⚠️
...wizards/online_bank_statement_provider_existing.py 0.00% 1 Missing ⚠️
...nto/models/online_bank_statement_provider_qonto.py 0.00% 1 Missing ⚠️
...le/models/account_statement_import_sheet_parser.py 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             16.0     #589      +/-   ##
==========================================
- Coverage   85.71%   83.98%   -1.74%     
==========================================
  Files          73       95      +22     
  Lines        2794     3310     +516     
  Branches      413      383      -30     
==========================================
+ Hits         2395     2780     +385     
- Misses        286      397     +111     
- Partials      113      133      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants