Automatically close non matching tiles#4
Open
alexiosmakris wants to merge 82 commits intobradlygreen:masterfrom
Open
Automatically close non matching tiles#4alexiosmakris wants to merge 82 commits intobradlygreen:masterfrom
alexiosmakris wants to merge 82 commits intobradlygreen:masterfrom
Conversation
the best practice is not to use angular markup in index.html so
the hide/show thing is not needed.
instead of <div>{{foo}}</div> use <div ng:bind="foo"></div> in
index.html. In other templates it is totally fine to use markup.
Added basic configuration, so all you need to run e2e tests: 1/ start web server in project root >> ./scripts/web-server.js 2/ start JsTD server >> ./scripts/e2e-test-server.sh 3/ capture some browser navigate to http://localhost:9877/capture 4/ run the tests >> ./scripts/e2e-test.sh
- change forward slash into back slash in Win scripts - split params to new lines - remove $tests option as it makes no sense now
…more than one space (aka %20) in the name
Simple text and replace and it works on node 0.8.
Added link to cloudbees clickstart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can you please inform about how to automatically close the tiles that are not matching, instead of having to click to another one to make them close?
I have tried pasting the following lines
this.firstPick.flip();
this.secondPick.flip();
this.firstPick = this.secondPick = undefined;
under these ones
this.secondPick = tile;
this.message = Game.MESSAGE_MISS;
on the file game.js, but that makes the second tile not open at all.
I put them in a setTimeout function, but then I get the error "Cannot read property 'flip' of undefined".
Thank you very much for time.