fix issue 242: do not apply element colors when resetting flows of an…

[pmeyer-viadee]

Fixes #242

Proposed Changes

Do not apply permanent colors to flows of Inclusive Gateways when resetting them.
I oriented myself on the (correctly working) ExclusiveGatewaySettings.resetSequenceFlow logic.

Demo after fix:
After toggling the token simulation on and off, and saving the diagram, the xml is not different from before anymore.

Steps to try out: see #242

Checklist

To ensure you provided everything we need to look at your PR:

• Brief textual description of the changes present
• Visual demo attached
• Steps to try out present, i.e. using the @bpmn-io/sr tool
• Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

[CLAassistant]

All committers have signed the CLA.

[nikku]

Thanks for your PR. I verified it fixes the issue.

Root cause

• We set colors after other components kick in to reset them, hence they remain set permanently
• Solution: Either not set colors during reset, or hook into TOGGLE_SIMULATION with high priority, so other behaviors (resetting colors) kicks in later.

I'm fine with the path you took, aligning both behaviors.

Follow-ups needed

In order for us to merge the contribution:

• Ensure that the commit message fits with our conventional commit guidelines, i.e.

  fix(inclusive-gateway-settings): do not flow colors during reset
  
  Closes #242 
  

• Consider to add a test case in the spirit of this, in test/spec/features/inclusive-gateway-settings, verifying the issue and fix. This way we don't accidentally unbuild your fix in the future.

Thanks for your contribution!

[pmeyer-viadee]

Hi Nico,
thanks for your feedback.
I updated the commit message and provided a test for all gateways, verifying the xml remains unchanged after toggling the simulation on and off.
Let me know if there is anything more to do.

[nikku]

Thanks for the update! I slightly simplified the tests and squashed the changes via 20591cc. Awesome contribution.

[nikku]

Released as v0.38.2.