Skip to content

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Sep 27, 2025

Proposed Changes

This is not a bug, and this was NOT introduced by my recent refactors (I intentionally preserved this oversight so that we can treat it separately.

The option name has never matched here, but the current execution path for the deprecated option does nothing on its own, it only does something when latest is set to true, so this parameter never did anything even if it didn't match the downstream object destructuring.

We can go forward in multiple ways:

  • adjust it for now for semantics more than anything and prevent this from becoming a bug in the future if we change the template finding logic (ie just merge this pr)
  • completely remove it
  • implement what this parameter would do on its own in the template finding logic
  • add options to getAll on top of the previous to support getAll(filter, { deprecated: false })

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Currently worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant