Skip to content

feat: show unknown element template id in linting and properties panel #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: show unknown element template id in linting and properties panel #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/element-templates.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,5 @@
.bio-properties-panel-deprecated-template-text,
.bio-properties-panel-template-incompatible-text {
width: 216px;
overflow-wrap: break-word;
}
2 changes: 1 addition & 1 deletion src/cloud-element-templates/linting/rules/element-templates-validate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default function({ templates = [] }) {
if (templateId && !template) {
reporter.report(
node.id,
'Linked element template not found',
`Linked element template '${templateId}' not found`,
{
name: node.name
}
Expand Down
15 changes: 8 additions & 7 deletions src/components/ElementTemplatesGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ function TemplateGroupButtons({ element, getTemplateId }) {
} else if (templateState.type === 'KNOWN_TEMPLATE') {
return <AppliedTemplate element={ element } />;
} else if (templateState.type === 'UNKNOWN_TEMPLATE') {
return <UnknownTemplate element={ element } />;
return <UnknownTemplate element={ element } templateState={ templateState } />;
} else if (templateState.type === 'DEPRECATED_TEMPLATE') {
return <DeprecatedTemplate element={ element } templateState={ templateState } />;
} else if (templateState.type === 'INCOMPATIBLE_TEMPLATE') {
Expand Down Expand Up @@ -203,12 +203,12 @@ function RemoveTemplate() {
return <span class="bio-properties-panel-remove-template">{ translate('Remove') }</span>;
}

function UnknownTemplate({ element }) {
function UnknownTemplate({ element, templateState }) {
const translate = useService('translate'),
elementTemplates = useService('elementTemplates');

const menuItems = [
{ entry: <NotFoundText /> },
{ entry: <NotFoundText templateState={ templateState } /> },
{ separator: true },
{ entry: translate('Unlink'), action: () => elementTemplates.unlinkTemplate(element) },
{ entry: <RemoveTemplate />, action: () => elementTemplates.removeTemplate(element) }
Expand All @@ -224,14 +224,15 @@ function UnknownTemplate({ element }) {
);
}

function NotFoundText() {
function NotFoundText({ templateState }) {
const translate = useService('translate');
const { templateId } = templateState;

return (
<div class="bio-properties-panel-template-not-found-text">
{ translate(
'The template applied was not found. Therefore, its properties cannot be shown. Unlink to access the data.'
) }
{ (translate(
'The applied template with id \'{templateId}\' was not found. Its properties cannot be shown. Unlink to access the data.'
)).replace('{templateId}', `${templateId}`) }
</div>
);
}
Expand Down
4 changes: 2 additions & 2 deletions test/spec/cloud-element-templates/linting/LinterPlugin.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const invalid = [
},
report: {
id: 'Task_1',
message: 'Linked element template not found'
message: 'Linked element template \'missing-template\' not found'
}
},
{
Expand Down Expand Up @@ -307,7 +307,7 @@ describe('cloud-element-templates/linting', function() {
// then
const report = secondResult['element-templates/validate'][0];
expect(report).to.have.property('id', 'Task_1');
expect(report).to.have.property('message', 'Linked element template not found');
expect(report).to.have.property('message', 'Linked element template \'constraints.empty\' not found');
});
});

Expand Down