fix(disk): restore updating boot disk. #2150

Vaneixus · 2025-09-07T03:19:04Z

Contributor's Note

I have added / updated documentation in /docs for any user-facing features or additions.
I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #0000 | Relates #0000

gemini-code-assist

Summary of Changes

Hello @Vaneixus, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a limitation in updating virtual machine boot disks by implementing a more robust mechanism for handling disk import operations. It ensures that necessary VM state transitions, such as shutdowns and reboots, are correctly orchestrated when disk configurations are modified, particularly for bootable volumes. The changes improve the reliability and functionality of disk management within the system.

Highlights

Boot Disk Update Restoration: The pull request restores the ability to update boot disks by correctly handling the ImportFrom parameter. Previously, ImportFrom was not sent for existing disks due to issues with re-importing boot disks, but now it is conditionally sent, triggering a necessary VM shutdown and reboot.
VM State Management for Disk Updates: The VM update process has been refined to properly manage the virtual machine's state during disk updates. A new shutdownBeforeUpdate flag is introduced to ensure the VM is gracefully shut down before applying disk changes that require it, and then restarted if it was originally running.
Function Signature Update: The Update function in proxmoxtf/resource/vm/disk/disk.go now returns an additional boolean value, shutdownBeforeUpdate, to indicate whether a VM shutdown is required before applying disk changes. This change is propagated to calling functions and tests.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Vaneixus · 2025-09-07T03:20:19Z

This is currently untested. but the end goal is restoring the updating of disks already in vm via import-from. it should work for all other disks, but the boot disk needs the vm to be offline before it gets updated.

gemini-code-assist

Code Review

This pull request aims to enable updating a boot disk, which involves re-importing it. The changes in proxmoxtf/resource/vm/disk/disk.go correctly identify that this operation requires the VM to be shut down. However, the implementation in proxmoxtf/resource/vm/vm.go has a flaw: while it correctly shuts down the VM for the update, it fails to restart it afterward, even if the VM is configured to be running. This leaves the resource in an inconsistent state. My review includes a critical fix to ensure the VM is restarted when required, restoring it to its configured state after the update.

proxmoxtf/resource/vm/vm.go

Vaneixus · 2025-09-07T03:21:29Z

I might need to add another parameter to identify boot disks to the update disk function.

Signed-off-by: Marco Attia <[email protected]>

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Marco Attia <[email protected]>

Signed-off-by: Marco Attia <[email protected]>

bpg

Hey @Vaneixus 👋🏼!

Thank you for looking into that, and contributing the fix, but I have a few questions.

bpg · 2025-09-09T23:56:35Z

proxmoxtf/resource/vm/disk/disk.go

+			if disk.ImportFrom != nil && *disk.ImportFrom != "" {
+				rebootRequired = true
+				shutdownBeforeUpdate = true
+				tmp.DatastoreID = disk.DatastoreID
+				tmp.ImportFrom = disk.ImportFrom
+				tmp.Size = disk.Size
+			}


this part was specifically removed here
so I think this change will break the VM update scenario, when VM has an imported disk.

What was the reason for adding this back?

Hello again @bpg, the reason this was re-added was that the boot disk cannot be changed while the vm is running, you can only change it while it isn't, at least that's what I remember being the case back when I opened the first PR. This PR is currently untested. I just opened it as to show my progress. I should have probably put it as a draft. It's also why I move the start-up/shutdown code, I probably have to change that part again. But basically, the whole idea is to shut down the vm to allow the boot disk to be changed. I just haven't had the opportunity to test this again. I will be working again on this PR on the weekend.

proxmoxtf/resource/vm/vm.go

Signed-off-by: Marco Attia <[email protected]>

Vaneixus · 2025-09-22T00:55:45Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a fix to allow updating a VM's boot disk by re-importing it, which correctly identifies that a VM shutdown is required. The changes are well-propagated from the disk update logic to the main VM update function, including logic to prevent redundant shutdowns. My review includes a suggestion to fix a logic issue in the VM start/stop handling and to add test coverage for the new disk update scenario.

proxmoxtf/resource/vm/disk/disk_test.go

Vaneixus · 2025-09-22T01:05:28Z

Hello BPG, I already ran a very basic update on an existing cluster, it seems to work according to PVE's logs. feel free to run a test and check it out. I haven't actually checked the content inside of the disks, but proxmox gave me a new import entry in the logs so it should have replaced it successfully. I will probably be testing other stuff such as no change. but the basic functionality seems to be working. I will also probably have an another change or two to be done, such as in case the VM is already shutdown since it seems I am not handling that as of yet.

Signed-off-by: Marco Attia <[email protected]>

Vaneixus · 2025-11-09T02:48:25Z

Sorry for the delays, lack of time and that I wanted to test this extensively and make sure it works correctly took some time. I am currently running the last of my tests and so it should be ready to go. I am able to have the Boot HDD replaced even if the VM is already running, Just have to stop it, update the disk then start the VM again. I will need to update the documentation to mention that, just so no one updates the disk and expects the VM to continue running. As for the old one, it merely gets detached, nothing gets permanently deleted, so yeah).

Edit: And this time I tested the actual images uploaded with a changing creation date that I can check and see if the VM is indeed running the same or newer build of my test image.

Vaneixus · 2025-11-09T03:28:40Z

Before:

Node Logs:

Cluster Logs:

TF Deployment Logs:

terraform apply
╷
│ Warning: Provider development overrides are in effect
│ 
│ The following provider development overrides are set in the CLI configuration:
│  - bpg/proxmox in /workspaces/Infrastructure/src/.terraform/providers/registry.opentofu.org/bpg/proxmox
│ 
│ The behavior may therefore not match any released version of the provider and applying changes may cause the state to become incompatible with published
│ releases.
╵
random_password.automation_user_password: Refreshing state... [id=none]
proxmox_virtual_environment_pool.workstation: Refreshing state... [id=Workstation]
data.proxmox_virtual_environment_nodes.all_nodes: Reading...
proxmox_virtual_environment_pool.security: Refreshing state... [id=Security]
proxmox_virtual_environment_pool.infrastructure: Refreshing state... [id=Infrastructure]
proxmox_virtual_environment_apt_standard_repository.no-subscription["node01"]: Refreshing state... [id=apt_standard_repository_node01_no_subscription]
proxmox_virtual_environment_download_file.almalinux_10_dvd_iso["node01"]: Refreshing state... [id=local:iso/AlmaLinux-10.0-x86_64-dvd.iso]
data.proxmox_virtual_environment_datastores.import["node01"]: Reading...
proxmox_virtual_environment_cluster_options.options: Refreshing state... [id=cluster]
data.proxmox_virtual_environment_datastores.isos["node01"]: Reading...
proxmox_virtual_environment_apt_standard_repository.ceph-squid-no-subscription["node01"]: Refreshing state... [id=apt_standard_repository_node01_ceph_squid_no_subscription]
proxmox_virtual_environment_pool.networking: Refreshing state... [id=Networking]
proxmox_virtual_environment_apt_standard_repository.ceph-quincy-enterprise["node01"]: Refreshing state... [id=apt_standard_repository_node01_ceph_quincy_enterprise]
data.proxmox_virtual_environment_nodes.all_nodes: Read complete after 0s [id=nodes]
proxmox_virtual_environment_apt_standard_repository.enterprise["node01"]: Refreshing state... [id=apt_standard_repository_node01_enterprise]
data.proxmox_virtual_environment_datastores.images["node01"]: Reading...
proxmox_virtual_environment_pool.media: Refreshing state... [id=Media]
proxmox_virtual_environment_user.terraform: Refreshing state... [id=terraform@pve]
proxmox_virtual_environment_time.first_node_time["nebuloso03"]: Refreshing state... [id=nebuloso03_time]
proxmox_virtual_environment_time.first_node_time["nebuloso02"]: Refreshing state... [id=nebuloso02_time]
proxmox_virtual_environment_time.first_node_time["node01"]: Refreshing state... [id=node01_time]
proxmox_virtual_environment_apt_repository.no-subscription["node01"]: Refreshing state... [id=apt_repository_node01_etc_apt_sources_list_3]
proxmox_virtual_environment_apt_repository.ceph-quincy-enterprise["node01"]: Refreshing state... [id=apt_repository_node01_etc_apt_sources_list_d_ceph_list_0]
proxmox_virtual_environment_apt_repository.enterprise["node01"]: Refreshing state... [id=apt_repository_node01_etc_apt_sources_list_d_pve_enterprise_list_0]
proxmox_virtual_environment_apt_repository.ceph-squid-no-subscription["node01"]: Refreshing state... [id=apt_repository_node01_etc_apt_sources_list_d_ceph_list_1]
data.proxmox_virtual_environment_datastores.import["node01"]: Read complete after 0s
data.proxmox_virtual_environment_datastores.images["node01"]: Read complete after 0s
data.proxmox_virtual_environment_datastores.isos["node01"]: Read complete after 0s
proxmox_virtual_environment_file.vm_qcow2["node01"]: Refreshing state... [id=local:import/f2df_vm.example.com.qcow2]
proxmox_virtual_environment_vm.vm["node01"]: Refreshing state... [id=21002]

OpenTofu used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

OpenTofu will perform the following actions:

  # proxmox_virtual_environment_file.vm_qcow2["node01"] must be replaced
-/+ resource "proxmox_virtual_environment_file" "vm_qcow2" {
      ~ file_modification_date = "2025-11-09T03:10:51Z" -> (known after apply)
      ~ file_name              = "f2df_vm.example.com.qcow2" -> (known after apply)
      ~ file_size              = 1124139520 -> (known after apply)
      ~ file_tag               = "6910063b-43010200" -> (known after apply)
      ~ id                     = "local:import/f2df_vm.example.com.qcow2" -> (known after apply)
        # (5 unchanged attributes hidden)

      ~ source_file {
          ~ file_name = "f2df_vm.example.com.qcow2" -> "17c5_vm.example.com.qcow2" # forces replacement
            # (3 unchanged attributes hidden)
        }
    }

  # proxmox_virtual_environment_vm.vm["node01"] will be updated in-place
  ~ resource "proxmox_virtual_environment_vm" "vm" {
        id                      = "21002"
        name                    = "vm01.example.com"
        tags                    = []
        # (30 unchanged attributes hidden)

      ~ disk {
          ~ import_from       = "local:import/f2df_vm.example.com.qcow2" -> (known after apply)
            # (12 unchanged attributes hidden)
        }

        # (10 unchanged blocks hidden)
    }

Plan: 1 to add, 1 to change, 1 to destroy.

Do you want to perform these actions?
  OpenTofu will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

proxmox_virtual_environment_file.vm_qcow2["node01"]: Destroying... [id=local:import/f2df_vm.example.com.qcow2]
proxmox_virtual_environment_file.vm_qcow2["node01"]: Destruction complete after 0s
proxmox_virtual_environment_file.vm_qcow2["node01"]: Creating...
proxmox_virtual_environment_file.vm_qcow2["node01"]: Still creating... [10s elapsed]
proxmox_virtual_environment_file.vm_qcow2["node01"]: Still creating... [20s elapsed]
proxmox_virtual_environment_file.vm_qcow2["node01"]: Still creating... [30s elapsed]
proxmox_virtual_environment_file.vm_qcow2["node01"]: Still creating... [40s elapsed]
proxmox_virtual_environment_file.vm_qcow2["node01"]: Still creating... [50s elapsed]
proxmox_virtual_environment_file.vm_qcow2["node01"]: Still creating... [1m0s elapsed]
proxmox_virtual_environment_file.vm_qcow2["node01"]: Still creating... [1m10s elapsed]
proxmox_virtual_environment_file.vm_qcow2["node01"]: Still creating... [1m20s elapsed]
proxmox_virtual_environment_file.vm_qcow2["node01"]: Creation complete after 1m23s [id=local:import/17c5_vm.example.com.qcow2]
proxmox_virtual_environment_vm.vm["node01"]: Modifying... [id=21002]
proxmox_virtual_environment_vm.vm["node01"]: Still modifying... [id=21002, 10s elapsed]
proxmox_virtual_environment_vm.vm["node01"]: Still modifying... [id=21002, 20s elapsed]
proxmox_virtual_environment_vm.vm["node01"]: Still modifying... [id=21002, 30s elapsed]
proxmox_virtual_environment_vm.vm["node01"]: Modifications complete after 30s [id=21002]

Apply complete! Resources: 1 added, 1 changed, 1 destroyed.

After:

The order in the Node Logs is incorrect for some reason, or rather, it might be unrelated, but if we look at the cluster jobs, we can see it executed the shutdown, the update then the start up in order.

As for my testing proccedures?
I am testing the following:
Started State + Disk Update
Stopped State + Disk Update
Started State + Disk Update + Stop
Stopped State + Disk Update + Start

Oh and if we check the TF Logs, it's an in-place update, so the other disks aren't modified or destroyed, the VM is safe for usage in disk update scenarios.

And I will need to add the test Gemini recommended as well as a last thing to do.

Signed-off-by: Marco Attia <[email protected]>

Vaneixus · 2025-11-10T02:29:08Z

Good Evening @bpg, I have finished my testing and I have ran the scenarios above and added the following:
State Change(Started => Shutdown) and vice versa with no disk updates. to test if the disk changes have not broken the power control via Terraform.
I have also updated the existing test cases with new tests to check the code functionality. I am now confident that this PR is now ready for review and integration. I would also say that I have not tested the make example command.

Vaneixus · 2025-11-10T02:29:32Z

/gemini review

gemini-code-assist

Code Review

This pull request correctly restores the ability to update a boot disk by changing the import_from attribute. The core logic involves detecting this change, triggering a VM shutdown, and then applying the disk update. The related changes in vm.go to handle the shutdown signal and avoid duplicate shutdowns are also well-implemented. I've found a minor typo in the documentation and some issues in the new test case that should be addressed to ensure correctness and clarity. Overall, this is a good fix for the issue.

docs/resources/virtual_environment_vm.md

proxmoxtf/resource/vm/disk/disk_test.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Marco Attia <[email protected]>

Signed-off-by: Marco Attia <[email protected]>

bpg · 2025-11-17T13:53:29Z

@Vaneixus thanks for the update. I've ran existing acceptance tests on this branch and see some test failures. I'll dig a bit to see why it started failing

=== NAME  TestAccResourceVMDisks/update_single_disk_without_affecting_boot_disk_with_import_from
    resource_vm_disks_test.go:1246: Step 2/2 error: After applying this test step, the non-refresh plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # proxmox_virtual_environment_vm.test_bootdisk_bug will be updated in-place
          ~ resource "proxmox_virtual_environment_vm" "test_bootdisk_bug" {
                id                      = "107"
                name                    = "test-bootdisk-bug"
                tags                    = []
                # (31 unchanged attributes hidden)
        
              ~ disk {
                  ~ size              = 0 -> 6
                    # (14 unchanged attributes hidden)
                }
        
                # (1 unchanged block hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.

Vaneixus · 2025-11-17T14:25:45Z

@Vaneixus thanks for the update. I've ran existing acceptance tests on this branch and see some test failures. I'll dig a bit to see why it started failing

=== NAME  TestAccResourceVMDisks/update_single_disk_without_affecting_boot_disk_with_import_from
    resource_vm_disks_test.go:1246: Step 2/2 error: After applying this test step, the non-refresh plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # proxmox_virtual_environment_vm.test_bootdisk_bug will be updated in-place
          ~ resource "proxmox_virtual_environment_vm" "test_bootdisk_bug" {
                id                      = "107"
                name                    = "test-bootdisk-bug"
                tags                    = []
                # (31 unchanged attributes hidden)
        
              ~ disk {
                  ~ size              = 0 -> 6
                    # (14 unchanged attributes hidden)
                }
        
                # (1 unchanged block hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.

Ah, sorry about that, I ran the normal tests(via make test) and all passed. Anyways, I will take a look as well into why they're failing.

Vaneixus · 2025-11-17T14:30:40Z

@bpg I think I see why. It is in the class name, "update_single_disk_without_affecting_boot_disk_with_import_from". It's a test case that was created when we had the bug where if we tried to update the disk while the VM is running, it would fail. This test case should no longer be relevant after the PR is pushed. Basically, no disk update after creation was the intention behind it. Perhaps we can add new acceptance test scenarios to check the new code instead.

bpg · 2025-11-20T02:03:28Z

@bpg I think I see why. It is in the class name, "update_single_disk_without_affecting_boot_disk_with_import_from". It's a test case that was created when we had the bug where if we tried to update the disk while the VM is running, it would fail. This test case should no longer be relevant after the PR is pushed. Basically, no disk update after creation was the intention behind it. Perhaps we can add new acceptance test scenarios to check the new code instead.

I don't think that's the case. The VM has started = false so it is not running, and any disk updates should be allowed.
The error tells that after applying the config from the test, the size of the disk in the TF state was 0, while the config says it should be 6. I.e. if you re-apply the same config it will try to update disk size 0 -> 6.

I'm not exactly sure why tho, this line

tmp.Size = disk.Size

seems to be the root cause, and disk.Size is probably 0 in this particular use case.

Sorry, can't say much more about this without digging deeper with a debugger.

Vaneixus · 2025-11-20T02:11:54Z

@bpg I think I see why. It is in the class name, "update_single_disk_without_affecting_boot_disk_with_import_from". It's a test case that was created when we had the bug where if we tried to update the disk while the VM is running, it would fail. This test case should no longer be relevant after the PR is pushed. Basically, no disk update after creation was the intention behind it. Perhaps we can add new acceptance test scenarios to check the new code instead.

I don't think that's the case. The VM has started = false so it is not running, and any disk updates should be allowed.
The error tells that after applying the config from the test, the size of the disk in the TF state was 0, while the config says it should be 6. I.e. if you re-apply the same config it will try to update disk size 0 -> 6.

I'm not exactly sure why tho, this line
tmp.Size = disk.Size
seems to be the root cause, and disk.Size is probably 0 in this particular use case.

Sorry, can't say much more about this without digging deeper with a debugger.

No worries! I will try and take a look later in the week/weekend.

pull-request-size bot added the size/M label Sep 7, 2025

gemini-code-assist bot reviewed Sep 7, 2025

View reviewed changes

proxmoxtf/resource/vm/vm.go Outdated Show resolved Hide resolved

Vaneixus and others added 3 commits September 7, 2025 03:30

fix(disk): restore updating boot disk.

47abbdb

Signed-off-by: Marco Attia <[email protected]>

fix(vm): restart vm after update is done.

b48de3e

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Marco Attia <[email protected]>

fix(lint): curly bracket indentation.

7d32487

Signed-off-by: Marco Attia <[email protected]>

Vaneixus force-pushed the Update_Disk_Via_Import branch from 963342a to 7d32487 Compare September 7, 2025 03:31

Merge branch 'main' into Update_Disk_Via_Import

2b72850

bpg reviewed Sep 10, 2025

View reviewed changes

bpg added the ⌛ pending author's response Requested additional information from the reporter label Sep 10, 2025

bpg marked this pull request as draft September 10, 2025 02:59

bpg removed the ⌛ pending author's response Requested additional information from the reporter label Sep 10, 2025

fix(vm): shutdown vm before updating boot disk.

43d1733

Signed-off-by: Marco Attia <[email protected]>

Vaneixus force-pushed the Update_Disk_Via_Import branch from 4006809 to 43d1733 Compare September 22, 2025 00:46

Vaneixus marked this pull request as ready for review September 22, 2025 00:47

Merge branch 'main' into Update_Disk_Via_Import

f9004e9

Signed-off-by: Marco Attia <[email protected]>

gemini-code-assist bot reviewed Sep 22, 2025

View reviewed changes

proxmoxtf/resource/vm/disk/disk_test.go Outdated Show resolved Hide resolved

Vaneixus marked this pull request as draft September 22, 2025 01:07

Vaneixus added 4 commits September 21, 2025 21:08

Remove blank line in vm.go

c67b910

Signed-off-by: Marco Attia <[email protected]>

Merge branch 'main' into Update_Disk_Via_Import

abe7fbd

Merge branch 'bpg:main' into Update_Disk_Via_Import

0c3e1ff

fix(vm): vm start happening twice.

911c591

Signed-off-by: Marco Attia <[email protected]>

Vaneixus force-pushed the Update_Disk_Via_Import branch from a2ea017 to 911c591 Compare November 9, 2025 02:44

fix(docs): update documentation for import-from.

21b9694

Signed-off-by: Marco Attia <[email protected]>

Vaneixus force-pushed the Update_Disk_Via_Import branch from cbbedd9 to 21b9694 Compare November 9, 2025 03:41

feat(disk): improved import-from disk testing.

58bb9c0

Signed-off-by: Marco Attia <[email protected]>

pull-request-size bot added size/L and removed size/M labels Nov 10, 2025

Vaneixus marked this pull request as ready for review November 10, 2025 02:26

gemini-code-assist bot reviewed Nov 10, 2025

View reviewed changes

docs/resources/virtual_environment_vm.md Outdated Show resolved Hide resolved

proxmoxtf/resource/vm/disk/disk_test.go Show resolved Hide resolved

Vaneixus and others added 2 commits November 9, 2025 21:32

Update docs/resources/virtual_environment_vm.md

a407f4f

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Marco Attia <[email protected]>

feat(disk): improved import-from disk testing.

45847b0

Signed-off-by: Marco Attia <[email protected]>

Vaneixus requested a review from bpg November 10, 2025 02:39

Merge branch 'main' into Update_Disk_Via_Import

bf9d532

bpg added the 📋 on my todo label Nov 17, 2025

bpg added ⌛ pending author's response Requested additional information from the reporter and removed 📋 on my todo labels Nov 20, 2025

Uh oh!

fix(disk): restore updating boot disk. #2150

Are you sure you want to change the base?

fix(disk): restore updating boot disk. #2150

Uh oh!

Conversation

Vaneixus commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contributor's Note

Proof of Work

Community Note

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

Vaneixus commented Sep 7, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Vaneixus commented Sep 7, 2025

Uh oh!

bpg left a comment

Choose a reason for hiding this comment

Uh oh!

bpg Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Vaneixus Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Vaneixus commented Sep 22, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Vaneixus commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vaneixus commented Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vaneixus commented Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vaneixus commented Nov 10, 2025

Uh oh!

Vaneixus commented Nov 10, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

bpg commented Nov 17, 2025

Uh oh!

Vaneixus commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vaneixus commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bpg commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vaneixus commented Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Vaneixus commented Sep 7, 2025 •

edited

Loading

Vaneixus commented Sep 22, 2025 •

edited

Loading

Vaneixus commented Nov 9, 2025 •

edited

Loading

Vaneixus commented Nov 9, 2025 •

edited

Loading

Vaneixus commented Nov 17, 2025 •

edited

Loading

Vaneixus commented Nov 17, 2025 •

edited

Loading

bpg commented Nov 20, 2025 •

edited

Loading