[FEATURE] Set up colours, shadow, spacing and generic variables #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlecrome
force-pushed
the
bwp-84-colours
branch
from
f806ccc to
fa85e9a
Compare
jdamner
reviewed
Feb 26, 2025
Comment on lines
+255
to
+256
| "name": "Poppins", | ||
| "slug": "poppins" |
There was a problem hiding this comment.
Should we name the fonts here as body and title etc? Most sites typically have two fonts so we can easily swap in the fontFamily above but keep the slug & name the same so that other code doesn't have to change?
| } | ||
| }, | ||
| "typography": { | ||
| "fontFamily": "var(--wp--preset--font-family--open-sans)" |
There was a problem hiding this comment.
Like here, this font-family doesn't exist right?
Comment on lines
+275
to
+284
| { | ||
| "name": "xlarge (40px)", | ||
| "size": "40px", | ||
| "slug": "xlarge" | ||
| }, | ||
| { | ||
| "name": "xxlarge (96px)", | ||
| "size": "96px", | ||
| "slug": "xxlarge" | ||
| } |
There was a problem hiding this comment.
Should we be using clamp() for these larger values? I've not looked at the Figma tbh, but seems like we'd benefit from having scaling type-ramps at the largest sizes.
There was a problem hiding this comment.
Potentially you could use the custom.spacing sizes too, to make the whole scale of things change together? Maybe one to chat about in the next UI/UX catchup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.