feat(content-sidebar): added onUserInteraction prop to BoxAISidebar #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,6 @@ import { | |||
| ClearConversationButton, | |||
| IntelligenceModal, | |||
| withApiWrapper, | |||
| // @ts-expect-error - TS2305 - Module '"@box/box-ai-content-answers"' has no exported member 'ApiWrapperWithInjectedProps'. | |||
| @@ -83,11 +83,14 @@ function BoxAISidebarContent(props: ApiWrapperWithInjectedProps) { | |||
| setCacheValue('agents', { agents, requestState, selectedAgent }); | |||
| } | |||
|
|
|||
| const handleUserIntentToUseAI = () => { | |||
| const handleUserIntentToUseAI = (userHasInteracted: boolean = false) => { | |||
There was a problem hiding this comment.
[nit] I think hasUserInteracted would be more proper form
There was a problem hiding this comment.
That might be true, however I've named it the same way in content-answers, so for consistency I'd leave it like that.
kkuliczkowski-box
force-pushed
the
content-sidebar/box-ai-handle-user-interaction-prop
branch
from
ad4aaf4 to
3566980
Compare
| @@ -423,4 +424,14 @@ describe('elements/content-sidebar/BoxAISidebar', () => { | |||
| expect(mockSendQuestion).not.toHaveBeenCalled(); | |||
| }, | |||
| ); | |||
|
|
|||
| test('should call onUserInteraction when user takes action', async () => { | |||
There was a problem hiding this comment.
Should we cover when userHasInteracted? Or is this covered in box-ai-content-answers?
There was a problem hiding this comment.
This test already covers that. onUserIntentToUseAI is called with userHasInteracted = true when user types in prompt. The logic of setting this param is inside content-answers.
jankowiakdawid
approved these changes
Mar 14, 2025
tjuanitas
approved these changes
Mar 14, 2025
kkuliczkowski-box
force-pushed
the
content-sidebar/box-ai-handle-user-interaction-prop
branch
from
3566980 to
5255c71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
onUserInteractionprop to BoxAISidebar to notify parent when user interacts with Box AI.