feat(boxai-sidebar): Modified suggested questions for images #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I've got a suggestion for a refactor.
How about we remove the logic of calculating localizedQuestions, for which we need to store file type extensions in constants. Instead let's move all that logic to useBoxAISidebarProps hook in EUA. Logic there will use already existing file type constants, so we don't have to duplicate and maintain them in multiple places.
We'll simply receive localizedQuestions in BUIE as a prop. This will also allow us to remove messages related to Suggested questions, so we won't need to maintain them as well.
jankowiakdawid
previously approved these changes
Feb 18, 2025
src/elements/content-sidebar/stories/tests/BoxAISidebar-visual.stories.tsx
Outdated
Show resolved
Hide resolved
DanilaRubleuski
force-pushed
the
box-ai-sidebar-suggestions
branch
from
0481343 to
9afd00b
Compare
kkuliczkowski-box
approved these changes
Feb 19, 2025
jankowiakdawid
approved these changes
Feb 19, 2025
tjuanitas
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Passed localizedQuestions list, which will be different depending on file format. It should be different for images, multiDoc and documents.
Screenshots