feat(box-ai): Update Shared packages versions #3926
Conversation
marcoartaviaq
force-pushed
the
update-ai-package
branch
from
a20db78 to
aeed2cc
Compare
marcoartaviaq
force-pushed
the
update-ai-package
branch
2 times, most recently
from
73e6dab to
28058fb
Compare
| submitQuestion={handleAsk} | ||
| suggestedQuestions={suggestedQuestions || localizedQuestions} | ||
| warningNotice={spreadsheetNotice} | ||
| warningNoticeAriaLabel={formatMessage(messages.welcomeMessageSpreadsheetNoticeAriaLabel)} | ||
| userInfo={userInfo} |
There was a problem hiding this comment.
New modal does not need userInfo nor onModalClose
There was a problem hiding this comment.
how does modal know who the user is? like for the avatar circle in the conversation box?
There was a problem hiding this comment.
Avatar circle wont appear anymore with lates design
| onOpenChange={handleOnRequestClose} | ||
| open={isOpen} | ||
| questions={questions} | ||
| retryQuestion={handleRetry} | ||
| setAnswerFeedback={undefined} |
There was a problem hiding this comment.
This failed the lint step if we didn't declare a value. For the moment, we pass undefined in order to not show the feedback yet
marcoartaviaq
force-pushed
the
update-ai-package
branch
4 times, most recently
from
a462d60 to
5d9b2bd
Compare
marcoartaviaq
force-pushed
the
update-ai-package
branch
from
5d9b2bd to
35ecf32
Compare
marcoartaviaq
force-pushed
the
update-ai-package
branch
from
35ecf32 to
e8d077d
Compare
| @@ -42,7 +42,6 @@ export interface ContentAnswersModalProps extends ExternalProps { | |||
|
|
|||
| const ContentAnswersModal = ({ | |||
| api, | |||
| currentUser, | |||
There was a problem hiding this comment.
you can remove the currentUser from the prop type and the withCurrentUser at the bottom
| submitQuestion={handleAsk} | ||
| suggestedQuestions={suggestedQuestions || localizedQuestions} | ||
| warningNotice={spreadsheetNotice} | ||
| warningNoticeAriaLabel={formatMessage(messages.welcomeMessageSpreadsheetNoticeAriaLabel)} | ||
| userInfo={userInfo} |
There was a problem hiding this comment.
how does modal know who the user is? like for the avatar circle in the conversation box?
| @@ -192,7 +192,6 @@ function BoxAISidebarContent(props: ApiWrapperProps) { | |||
| items={items} | |||
| itemSize={itemSize} | |||
| onClearAction={onClearAction} | |||
| onModalClose={handleModalClose} | |||
There was a problem hiding this comment.
why does this modal need the same prop changes as the ContentAnswers file? such as setAnswerFeedback or userInfo?
There was a problem hiding this comment.
box-ai-content-answers shared feature removed and added those props. This will apply for all uses in BUIE since the UI was updated
There was a problem hiding this comment.
whoops, word spaghetti. i meant to say: why does it not need the same prop changes as the other file? this file still passes userInfo and does not pass setAnswerFeedback
| @@ -8,7 +8,6 @@ import ContentAnswersModal from '../ContentAnswersModal'; | |||
| import { | |||
| mockApi, | |||
| mockApiReturnError, | |||
| mockCurrentUser, | |||
There was a problem hiding this comment.
similar here. this mock can be removed from the mocks file
marcoartaviaq
force-pushed
the
update-ai-package
branch
from
a96f58b to
e8d077d
Compare
Update packages to their latest version.
Some fixes needs to be done at test level since Box AI went into a redesign that changed the style and copy of the text