feat(metadata-sidebar): Use error code prop in MetadataInstanceEditor #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjuanitas
previously approved these changes
Feb 11, 2025
| @@ -58,6 +65,7 @@ const MetadataInstanceEditor: React.FC<MetadataInstanceEditorProps> = ({ | |||
| selectedTemplateInstance={template} | |||
| setIsUnsavedChangesModalOpen={setIsUnsavedChangesModalOpen} | |||
| taxonomyOptionsFetcher={taxonomyOptionsFetcher} | |||
| errorCode={errorCode} | |||
| @@ -290,6 +291,7 @@ function MetadataSidebarRedesign({ | |||
| setIsUnsavedChangesModalOpen={setIsUnsavedChangesModalOpen} | |||
| taxonomyOptionsFetcher={taxonomyOptionsFetcher} | |||
| template={editingTemplate} | |||
| errorCode={extractErrorCode} | |||
wpiesiak
reviewed
Feb 12, 2025
| @@ -214,15 +224,24 @@ function useSidebarMetadataFetcher( | |||
| metadata_template: { template_key: templateKey, scope, type: 'metadata_template' }, | |||
| })) as Record<string, MetadataFieldValue>; | |||
| } catch (error) { | |||
| if (isUserCorrectableError(error.status)) { | |||
| if (error.status === 408) { | |||
There was a problem hiding this comment.
Suggested change
| if (error.status === 408) { | |
| if (error.response.status === 408) { |
|
Can you also add clear error handler and trigger it for |
JChan106
force-pushed
the
extract-error
branch
from
d32663c to
f2e1b8a
Compare
wpiesiak
previously approved these changes
Feb 12, 2025
kajarosz
reviewed
Feb 12, 2025
src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx
Outdated
Show resolved
Hide resolved
kajarosz
approved these changes
Feb 12, 2025
jmcbgaston
approved these changes
Feb 12, 2025
tjuanitas
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes down the error code into MetadataInstanceEditor if there's an error extracting suggestions.