fix(content-sidebar): remove dependency on isSignRemoveInterstitialEnabled #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-in-a-box
changed the title
greg-in-a-box
changed the title
JChan106
previously approved these changes
Nov 4, 2024
GonchuB
reviewed
Nov 5, 2024
GonchuB
previously approved these changes
Nov 5, 2024
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
aea92d0 to
1020007
Compare
JChan106
previously approved these changes
Nov 5, 2024
greg-in-a-box
requested changes
Nov 5, 2024
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
1020007 to
bdba5eb
Compare
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
bdba5eb to
3b5d387
Compare
greg-in-a-box
requested changes
Nov 6, 2024
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
3b5d387 to
a982541
Compare
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
2 times, most recently
from
f4855fe to
8fd8f2e
Compare
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
8fd8f2e to
ba55f34
Compare
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
2 times, most recently
from
b0d2d93 to
8a40819
Compare
diogostavares
commented
Jan 14, 2025
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
3 times, most recently
from
cbf2ac3 to
f54b7ad
Compare
greg-in-a-box
requested changes
Jan 16, 2025
| }: Props) => { | ||
| const { enabled: hasBoxSign } = useFeatureConfig('boxSign'); | ||
| const { enabled: hasBoxSign } = signSideBarProps || {}; |
There was a problem hiding this comment.
is there a permission via the user that enables this feature too ?
There was a problem hiding this comment.
Yes, there is a user permission controlled by the admin that enables/disables signing. This is reflected in the enabled property sent by EUA
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
f54b7ad to
8aed68f
Compare
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
8aed68f to
60f54fc
Compare
greg-in-a-box
previously approved these changes
Feb 3, 2025
There was a problem hiding this comment.
approved but this feature has remain undocumented, normally all props at the root level is usable by 3rd customers sine this feature is only enabled by a flag and additional unknown permissions internally, we cant guarantee the 3rd party customers will be able to use it.
tjuanitas
reviewed
Feb 3, 2025
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
2 times, most recently
from
6e7c952 to
bf63860
Compare
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
2 times, most recently
from
7d214a8 to
6ba3efd
Compare
tjuanitas
previously approved these changes
Feb 18, 2025
| @@ -25,11 +25,11 @@ export type Props = PlainButtonProps & { | |||
|
|
|||
| export const PlaceholderTooltip = ({ children }: { children: React.ReactNode }) => children; | |||
|
|
|||
| export function SidebarNavSignButton({ blockedReason, intl, status, targetingApi, ...rest }: Props) { | |||
There was a problem hiding this comment.
can status be removed from prop type?
There was a problem hiding this comment.
yes, is safe to remove it. Updated
diogostavares
force-pushed
the
remove-removeInterstitial-ff-dependency
branch
from
6ba3efd to
f3071a5
Compare
tjuanitas
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isSignRemoveInterstitialEnabled feature flag was recently cleaned up on the application side, causing a production defect due to a dependency in this components. This PR removes the dependency in BUIE components to align with the application.
Also uses sign config in the primary props instead of feature props