-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use k8s namespaces #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, such a huuuge PR!! From what I can tell, it looks good, many very nice changes! I'm not super confident in my review though, because of the size 😅 I couldn't tell if the branch lacks some rebasing, since as you mention, it is dependent on other issues? If so, PLEASE rebase before readying it for review next time, so I can stop wasting time reviewing double (funny that you actually mentioned this yourself in the contributing readme lol). Otherwise, it would be good anyway to split things up a little, this one certainly does more than just using k8s namespaces.. 🤗
57b8356
to
edb4ba3
Compare
For sure! I based the following branches on the unmerged work in the branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @netr0m ! 🎉
This PR ensures that the CTF services are separated in their own namespace
juicer
, rather than using the defaultdefault
.Depends on #48
Depends on #49