Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use k8s namespaces #50

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Use k8s namespaces #50

merged 1 commit into from
Jan 31, 2024

Conversation

netr0m
Copy link
Contributor

@netr0m netr0m commented Dec 14, 2023

This PR ensures that the CTF services are separated in their own namespace juicer, rather than using the default default.

Depends on #48
Depends on #49

@netr0m netr0m added the 🔧 change Maintenance, cleanup or refactoring of existing code label Dec 14, 2023
@netr0m netr0m self-assigned this Dec 14, 2023
@netr0m netr0m requested a review from a team as a code owner December 14, 2023 16:00
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cluster-issuer.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@olavis olavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, such a huuuge PR!! From what I can tell, it looks good, many very nice changes! I'm not super confident in my review though, because of the size 😅 I couldn't tell if the branch lacks some rebasing, since as you mention, it is dependent on other issues? If so, PLEASE rebase before readying it for review next time, so I can stop wasting time reviewing double (funny that you actually mentioned this yourself in the contributing readme lol). Otherwise, it would be good anyway to split things up a little, this one certainly does more than just using k8s namespaces.. 🤗

@netr0m netr0m force-pushed the feat/use-namespace branch from 57b8356 to edb4ba3 Compare January 4, 2024 11:35
@netr0m
Copy link
Contributor Author

netr0m commented Jan 4, 2024

Wow, such a huuuge PR!! From what I can tell, it looks good, many very nice changes! I'm not super confident in my review though, because of the size 😅 I couldn't tell if the branch lacks some rebasing, since as you mention, it is dependent on other issues? If so, PLEASE rebase before readying it for review next time, so I can stop wasting time reviewing double (funny that you actually mentioned this yourself in the contributing readme lol). Otherwise, it would be good anyway to split things up a little, this one certainly does more than just using k8s namespaces.. 🤗

For sure! I based the following branches on the unmerged work in the branch refactor/make-cloud-agnostic, which made this and the previous branch/PR really noisy. I've merged the previous branches to main now, and rebased this one on top to make it more readable!

Copy link
Collaborator

@markusrf markusrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @netr0m ! 🎉

@netr0m netr0m merged commit 44ba7f2 into main Jan 31, 2024
@netr0m netr0m deleted the feat/use-namespace branch January 31, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 change Maintenance, cleanup or refactoring of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants