Remove unrecognised variable warning on grid load#338
Open
mikekryjak wants to merge 2 commits intomasterfrom
Open
Remove unrecognised variable warning on grid load#338mikekryjak wants to merge 2 commits intomasterfrom
mikekryjak wants to merge 2 commits intomasterfrom
Conversation
This prints an error when reading e.g. closed_wall due to it not being over [x,y,z] but rather a 1D array with [t] (I guess for a lack of a dummy dimension). I always have these variables and always get the warning.
Member
|
See also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This thing prints a warning every time I load a Hermes-3 dataset:
xBOUT/xbout/load.py
Lines 1155 to 1162 in 9b67b37
It's picking up
closed_wall_Randclosed_wall_Z, which are 1D arrays defined over the time dimension (I guess for a lack of a dummy dimension), and so cause an error due to not being over [x,y,z].This PR removes the warning. If anyone wants these variables, they can look to modify the code further to make sure they are read properly.