Merge pull request #11 from botlify-net/dev

add: new release see changelog md

Author: florianepitech

CHANGELOG.md

@@ -1,3 +1,7 @@
 Features:
-- Update dependencies
-- Lint code with two spaces
+- Update pom.xml with the latest version plugins
+- Update the dev contact to try to have a logo on the mvnrepository.com
+
+Fixes:
+- Fix possible dead log in PropertyFieldManager class file
+- Add version number in three parts in the pom.xml

pom.xml

@@ -6,11 +6,11 @@
 
   <groupId>net.botlify.dot-properties</groupId>
   <artifactId>dot-properties</artifactId>
-  <version>1.1</version>
+  <version>1.1.0</version>
 
   <name>Dot Properties</name>
   <url>https://github.com/botlify-net/dot-properties</url>
-  <description>Manage your properties file like a pro</description>
+  <description>Manage your properties config file with annotation.</description>
 
   <properties>
     <maven.compiler.source>17</maven.compiler.source>
@@ -25,9 +25,9 @@
   </organization>
 
   <scm>
-    <connection>scm:github:https://github.com/botlify-net/dot-properties</connection>
-    <developerConnection>scm:github:https://github.com/botlify-net/dot-properties</developerConnection>
     <url>https://github.com/botlify-net/dot-properties</url>
+    <connection>scm:git:git://github.com/botlify-net/dot-properties.git</connection>
+    <developerConnection>scm:git:[email protected]:botlify-net/dot-properties.git</developerConnection>
     <tag>master</tag>
   </scm>
 
@@ -83,7 +83,7 @@
           <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-gpg-plugin</artifactId>
-            <version>3.0.1</version>
+            <version>3.1.0</version>
             <executions>
               <execution>
                 <id>sign-artifacts</id>
@@ -148,7 +148,7 @@
       <groupId>org.projectlombok</groupId>
       <artifactId>lombok</artifactId>
       <version>1.18.30</version>
-      <scope>provided</scope>
+      <scope>compile</scope>
     </dependency>
   </dependencies>
 
@@ -158,7 +158,7 @@
         <!-- Build the JavaDoc -->
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-source-plugin</artifactId>
-        <version>3.2.1</version>
+        <version>3.3.0</version>
         <executions>
           <execution>
             <id>attach-sources</id>
@@ -173,9 +173,9 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-javadoc-plugin</artifactId>
-        <version>3.5.0</version>
+        <version>3.6.3</version>
         <configuration>
-          <source>1.8</source>
+          <source>${maven.compiler.source}</source>
           <failOnError>true</failOnError>
           <failOnWarnings>true</failOnWarnings>
         </configuration>
@@ -199,8 +199,15 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>3.11.0</version>
         <configuration>
-          <source>16</source>
-          <target>16</target>
+          <source>${maven.compiler.source}</source>
+          <target>${maven.compiler.target}</target>
+          <annotationProcessorPaths>
+            <path>
+              <groupId>org.projectlombok</groupId>
+              <artifactId>lombok</artifactId>
+              <version>1.18.30</version>
+            </path>
+          </annotationProcessorPaths>
         </configuration>
       </plugin>
     </plugins>

src/main/java/net/botlify/dotproperties/fields/PropertyFieldManager.java

@@ -23,7 +23,7 @@ public abstract class PropertyFieldManager {
   private static final List<PropertyField> fields = new ArrayList<>();
 
   /**
-   * The lock used to synchronize the access to the fields list.
+   * The lock used to synchronize the access to the field list.
    */
   private static final ReentrantLock lock = new ReentrantLock();
 
@@ -60,8 +60,11 @@ private PropertyFieldManager() {
    */
   public static void addPropertyField(@NotNull final PropertyField field) {
     lock.lock();
-    fields.add(field);
-    lock.unlock();
+    try {
+      fields.add(field);
+    } finally {
+      lock.unlock();
+    }
   }
 
   /**
@@ -78,27 +81,30 @@ public static boolean parseField(@NotNull final Object bean,
                                    @NotNull final Field field,
                                    @NotNull final String value) throws IllegalAccessException {
     lock.lock();
-    // Verify if the field is final.
-    if ((field.getModifiers() & Modifier.FINAL) == Modifier.FINAL) {
-      log.warn("Field {} is final, skipping updating", field.getName());
-      return (false);
-    }
-    // Verify if the field is primitive.
-    if (parsePrimitiveField(bean, field, value))
-      return (true);
-    for (PropertyField propertyField : fields) {
-      if (propertyField.getType() == field.getType()) {
-        try {
-          field.setAccessible(true);
-          field.set(bean, propertyField.parseString(value));
-          return (true);
-        } catch (IllegalAccessException e) {
-          log.error("Unable to set field {} to value {}", field.getName(), value, e);
-          return (false);
+    try {
+      // Verify if the field is final.
+      if ((field.getModifiers() & Modifier.FINAL) == Modifier.FINAL) {
+        log.warn("Field {} is final, skipping updating", field.getName());
+        return (false);
+      }
+      // Verify if the field is primitive.
+      if (parsePrimitiveField(bean, field, value))
+        return (true);
+      for (PropertyField propertyField : fields) {
+        if (propertyField.getType() == field.getType()) {
+          try {
+            field.setAccessible(true);
+            field.set(bean, propertyField.parseString(value));
+            return (true);
+          } catch (IllegalAccessException e) {
+            log.error("Unable to set field {} to value {}", field.getName(), value, e);
+            return (false);
+          }
         }
       }
+    } finally {
+      lock.unlock();
     }
-    lock.unlock();
     log.warn("Unsupported field type {} for field {}",
         field.getType().getName(), field.getName());
     return (false);
@@ -150,9 +156,13 @@ private static boolean parsePrimitiveField(@NotNull final Object bean,
   public static @NotNull List<Class<?>> getImplementedClassList() {
     List<Class<?>> classes = new ArrayList<>();
     lock.lock();
-    for (PropertyField field : fields)
-      classes.add(field.getType());
-    lock.unlock();
+    try {
+      for (PropertyField field : fields) {
+        classes.add(field.getType());
+      }
+    } finally {
+      lock.unlock();
+    }
     return (classes);
   }