fix(webhooks): satisfy exactOptionalPropertyTypes on WEBHOOK_QUEUE + test typing - #552
Merged
Merged
Conversation
…test typing The deploy's run_checks typecheck (with the generated worker-configuration.d.ts) rejected the optional WEBHOOK_QUEUE plumbing and two test-only type nits: - EnqueueDeliveriesEnv.WEBHOOK_QUEUE -> (not just ), and emitWebhookEvent/handleWebhookQueue take EnqueueDeliveriesEnv directly so the optional-binding shape assigns cleanly under exactOptionalPropertyTypes. - webhook_queue.test env() casts the sendBatch-only stand-in to Queue<unknown> instead of spreading a partial object. - release_human_approval_migration.test (pre-existing, landed via #239 before the deploy-typecheck could see it): better-sqlite3 .get() is non-generic — use , the pattern sibling tests use. tsc --noEmit now reports 0 errors with worker-configuration.d.ts generated (deploy parity); all touched tests still pass. Signed-off-by: Volta <volta@mail.build>
bytemain
force-pushed
the
volta/webhook-typecheck-fix
branch
from
September 24, 2026 08:17
246f987 to
5b3623f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy's
run_checkstypecheck (with generatedworker-configuration.d.ts) rejected the optionalWEBHOOK_QUEUEplumbing + two test-only nits.EnqueueDeliveriesEnv.WEBHOOK_QUEUE → Queue | undefined; emitWebhookEvent/handleWebhookQueue takeEnqueueDeliveriesEnv; queue-test env() casts the stand-in toQueue<unknown>; and the pre-existing.get<T>()in release_human_approval_migration.test (landed via #239 before deploy-typecheck could see it) →.get() as T | undefined.tsc --noEmitnow 0 errors with worker-configuration.d.ts generated.