Fix/array access in function #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boriel
force-pushed
the
fix/array_access_in_function
branch
from
1a9eeb4 to
c7667c0
Compare
This required a revamp of the way the arrays were used. The array.asm runtime now uses the LBOUND table *always* unless the array is zero-based in all dimensions. On each iteration, the index is subtracted the i-th lower-bound. There is no longer the need to subtract it when pushing it.
boriel
force-pushed
the
fix/array_access_in_function
branch
2 times, most recently
from
f43b7a0 to
d681285
Compare
Now the routine is quite different. LBound and UBound tables are used to check boundaries.
boriel
force-pushed
the
fix/array_access_in_function
branch
from
d681285 to
1633ffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
Fixes #824