Skip to content

Remove condition on existance of /run/ostree-booted for bootc systemd units/timers - #2437

Open
godvino wants to merge 1 commit into
bootc-dev:mainfrom
godvino:ostree-condition
Open

Remove condition on existance of /run/ostree-booted for bootc systemd units/timers#2437
godvino wants to merge 1 commit into
bootc-dev:mainfrom
godvino:ostree-condition

Conversation

@godvino

@godvino godvino commented Sep 5, 2026

Copy link
Copy Markdown

This file is created by ostree backend and won't be present for systems using composefs backend

@bootc-bot
bootc-bot Bot requested a review from ckyrouac September 5, 2026 05:41

@Johan-Liebert1 Johan-Liebert1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't outright remove this. This should be OR'd with something like ConditionKernelCommandLine=composefs

@godvino

godvino commented Sep 8, 2026

Copy link
Copy Markdown
Author

We shouldn't outright remove this. This should be OR'd with something like ConditionKernelCommandLine=composefs

Done.

@Johan-Liebert1 Johan-Liebert1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2248 adds another kernel cmdline for composefs so we should not forget to add that in here as well once it's merged

@Johan-Liebert1

Copy link
Copy Markdown
Collaborator

Also, @godvino could you sign your commit with git commit -s --amend --no-edit. We require signed commits

@godvino

godvino commented Sep 9, 2026

Copy link
Copy Markdown
Author

Also, @godvino could you sign your commit with git commit -s --amend --no-edit. We require signed commits

Done.

@Johan-Liebert1

Copy link
Copy Markdown
Collaborator

Hmm... DCO's still failing. That command should've added a

Signed-off-by: <name> <email> 

Do you have name and email properly set up for git?

… units/timers.

This file is created by ostree backend and won't be present for systems using composefs backend

Signed-off-by: Godvin Ouseph <godvvino@gmail.com>
@godvino

godvino commented Sep 9, 2026

Copy link
Copy Markdown
Author

Hmm... DCO's still failing. That command should've added a

Signed-off-by: <name> <email> 

Do you have name and email properly set up for git?

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants