Skip to content

cli: graduate progress-fd out of experimental #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmarrero
Copy link
Contributor

@jmarrero jmarrero commented Jul 17, 2025

Stabilize progress-fd closing #1016.

Draft as we are still ironing out what else needs to be done before stabilizing.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 17, 2025
Signed-off-by: Joseph Marrero Corchado <[email protected]>
@jmarrero jmarrero force-pushed the remove-exp-progressfd branch from eb8339a to e3568e0 Compare July 17, 2025 19:38
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully promotes the --progress-fd feature from experimental to stable. The changes are consistent across the codebase, including updating dependencies in Cargo.lock and ostree-ext/Cargo.toml, adjusting the CLI visibility in lib/src/cli.rs, and updating the documentation to reflect the new status of the feature. The changes are well-executed and I have no further suggestions for improvement.

@cgwalters
Copy link
Collaborator

I know this is just starting things, but for reference a lot of discussion in #1016 which should be clearly linked here in the PR description etc. Did you have any feedback/thoughts there?

Overall...yeah we could just basically do this and move on for now...but...

Actually though, at least for Anaconda this won't be useful until we do #982

@jmarrero jmarrero mentioned this pull request Jul 18, 2025
3 tasks
@jmarrero
Copy link
Contributor Author

jmarrero commented Jul 18, 2025

I know this is just starting things, but for reference a lot of discussion in #1016 which should be clearly linked here in the PR description etc. Did you have any feedback/thoughts there?

Yeah, have had to read it a couple of times to understand the expectations here. Added a comment there and got some answers.

Actually though, at least for Anaconda this won't be useful until we do #982

OK, let's talk about that in #1016

@jmarrero jmarrero changed the title Remove exp progressfd cli: graduate progress-fd out of experimental Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants