Skip to content

fix: make indexed_range::accessor move constructible #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HDembinski merged 2 commits into from
Oct 12, 2026
Merged

fix: make indexed_range::accessor move constructible #444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2b0d31
fix: make indexed_range::accessor move constructible
henryiii Oct 11, 2026
11e8d0e
Apply suggestion from @henryiii
henryiii Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions include/boost/histogram/indexed.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ class BOOST_ATTRIBUTE_NODISCARD indexed_range {
with the algorithms of the standard library, the accessor is implicitly convertible to
a cell value. Assignments and comparisons are passed through to the cell. An accessor
is coupled to its parent indexed_range::iterator. Moving the parent iterator
forward also updates the linked accessor. Accessors are not copyable. They cannot be
stored in containers, but indexed_range::iterator can be stored.
forward also updates the linked accessor. Accessors are movable but not copyable.
They cannot be stored in containers, but indexed_range::iterator can be stored.
*/
class BOOST_ATTRIBUTE_NODISCARD accessor : detail::mirrored<accessor, void> {
public:
Expand Down Expand Up @@ -218,6 +218,9 @@ class BOOST_ATTRIBUTE_NODISCARD indexed_range {

operator value_type() const noexcept { return get(); }

// libc++ 21 std::generate binds the dereferenced iterator to a by-value parameter
accessor(accessor&&) = default;

private:
accessor(iterator& i) noexcept : iter_(i) {}

Expand Down
Loading