This fixes the Visual Studio 2019 warning W26451 #175
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Arithmetic overflow Using operator* on a 4 byte value and then casting the result to a 8 byte value.)
JeffGarland
reviewed
Nov 20, 2020
Collaborator
JeffGarland
left a comment
JeffGarland
left a comment
There was a problem hiding this comment.
probably a reasonable change -- would the impact be the same if we just changed the order to adjust*sub_sec so we wouldn't need the cast? In any case let's see how the CI likes the change...
Author
|
As far as I can see the now failing builds already failed without my change. I will check your proposal of swapping the factors. |
Collaborator
|
@FelixPetriconi rebase on develop for a complete CI scan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider this small fix to avoid a Visual Studio warning.
(Arithmetic overflow Using operator* on a 4 byte value and then casting the result to a 8 byte value.)