-
Notifications
You must be signed in to change notification settings - Fork 102
Sebastian Thunberg #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sebbsoon
wants to merge
1
commit into
boolean-uk:main
Choose a base branch
from
Sebbsoon:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ public class Exercise { | |
// 1. The brokenUrl member above contains an invalid URL. There's a z instead of an s in the protocol (httpz instead of https). | ||
// Using the `replace` method on brokenUrl, set the fixedUrl member below to the correct value. | ||
// https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/lang/String.html#replace(char,char) | ||
public String fixedUrl = ""; | ||
public String fixedUrl = brokenUrl.replace('z','s'); | ||
|
||
|
||
// Here's a documentation link for all string methods, use it to figure out how to complete the rest of these requirements: | ||
|
@@ -16,26 +16,26 @@ public class Exercise { | |
|
||
// 2. There are currently some upper case characters in the URL. Using an appropriate string method on the fixedUrl member above, | ||
// set the value of lowerCasedUrl. | ||
public String lowerCasedUrl = ""; | ||
public String lowerCasedUrl = fixedUrl.toLowerCase(); | ||
|
||
|
||
// 3. There is still white space on both ends of the URL! Use the appropriate string method to trim that white space | ||
// and set the value of the url member below | ||
public String url = ""; | ||
public String url = lowerCasedUrl.replace(" ",""); | ||
|
||
|
||
// 4. Using the appropriate string method on url, set the value of the protocol member below | ||
public String protocol = ""; | ||
public String protocol = url.split(":")[0]; | ||
|
||
|
||
// 5. Using the appropriate string method on url, set the value of the domain member below | ||
public String domain = ""; | ||
public String domain = url.replace("https://","").split("/")[0]; | ||
|
||
|
||
// 6. Set the length member below to the length of the url member | ||
public int length = 0; | ||
public int length = url.length(); | ||
|
||
|
||
// 7. Using concatenation and existing members, set the faqUrl member below to the faq page of the boolean website | ||
public String faqUrl = ""; | ||
public String faqUrl = protocol+"://"+domain+"/faq"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. spaces for readability! |
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trim()
is useful here (removes trailing whitespaces).