Skip to content

Jack Miller #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions src/routers/books.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,37 @@
// Import data here...
const express = require("express");
const router = express.Router();
const { books } = require("../../data/index");

// Define routes for /users here
router.get("/", (req, res) => {
res.json({ books: books });
});

// Write routes here...
router.get("/:id", (req, res) => {
const id = parseInt(req.params.id);
const book = books.find((u) => u.id === id);
res.json({ book: book });
});

router.post("/", (req, res) => {
const newBook = req.body;
newBook.id = books.length + 1;
books.push(newBook);
res.status(201).json({ book: newBook });
});

router.put("/:id", (req, res) => {
const id = parseInt(req.params.id);
const bookIndex = books.findIndex((b) => b.id === id);
books[bookIndex] = { ...books[bookIndex], ...req.body, id: id };
res.json({ book: books[bookIndex] });
});

router.delete("/:id", (req, res) => {
const id = parseInt(req.params.id);
const bookIndex = books.findIndex((b) => b.id === id);
const book = books.splice(bookIndex, 1)[0];
res.json({ book });
});

module.exports = router;
58 changes: 58 additions & 0 deletions src/routers/films.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
// Import data here...
const express = require('express')
const {films} = require("../../data/index")
const router = express.Router()


// Get request for all films
router.get("/", (req, res) => {
res.status(200).json({films: films})
})

// Get request for a single id
router.get("/:id", (req, res) => {
const id = parseInt(req.params.id);
const film = films.find((film) => film.id === id)

if(film){
return res.status(200).json({film: film})
} else {
return res.status(404).json({error: "No such film with this id"})
}
})

// Post request to create new film
router.post("/", (req, res) => {
const newFilm = req.body;
newFilm.id = films.length + 1;
films.push(newFilm);
return res.status(201).json({film: newFilm})
})

// Put request to update film
router.put("/:id", (req, res) => {
const id = parseInt(req.params.id);
const foundFilm = films.find(film => film.id === id)

const updates = req.body;
Object.assign(foundFilm, updates)

return res.status(200).json({film: foundFilm})
})

// Delete request to delete film
router.delete("/:id", (req, res) => {
const id = parseInt(req.params.id);
const foundFilmId = films.findIndex(film => film.id === id)

if(foundFilmId === -1){
return res.status(404).json({error: "No such film with this id"})
}

const deleteFilm = films.splice(foundFilmId, 1)[0];

return res.status(200).json({film: deleteFilm})
})

// Write routes here...
module.exports = router
39 changes: 39 additions & 0 deletions src/routers/users.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// users.js

const express = require("express");
const router = express.Router();
const { users } = require("../../data/index");

// Define routes for /users here
router.get("/", (req, res) => {
res.json({ users: users });
});

router.get("/:id", (req, res) => {
const id = parseInt(req.params.id);
const user = users.find((u) => u.id === id);
res.json({ user: user });
});

router.post("/", (req, res) => {
const newUser = req.body;
newUser.id = users.length + 1;
users.push(newUser);
res.status(201).json({ user: newUser });
});

router.put("/:id", (req, res) => {
const id = parseInt(req.params.id);
const userIndex = users.findIndex((u) => u.id === id);
users[userIndex] = { ...users[userIndex], ...req.body, id: id };
res.json({ user: users[userIndex] });
});

router.delete("/:id", (req, res) => {
const id = parseInt(req.params.id);
const userIndex = users.findIndex((u) => u.id === id);
const user = users.splice(userIndex, 1)[0];
res.json({ user });
});

module.exports = router;
9 changes: 6 additions & 3 deletions src/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@ app.use(morgan("dev"));

// REQUIRE ROUTERS
const usersRouter = require("./routers/users");
const filmsRouter = require("./routers/films")
const booksRouter = require("./routers/books")

// ADD ROUTERS TO APP
app.use('/users', usersRouter)
app.use('/films', filmsRouter)
app.use('/books', booksRouter)


module.exports = app
module.exports = app;
2 changes: 1 addition & 1 deletion test/api/routes/books.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,4 @@ describe("Books Endpoint", () => {
expect(responseAfter.body.books.length).toEqual(3)
})
})
})
})
2 changes: 1 addition & 1 deletion test/api/routes/films.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,4 @@ describe("Films Endpoint", () => {
expect(responseAfter.body.films.length).toEqual(3)
})
})
})
})
2 changes: 1 addition & 1 deletion test/api/routes/users.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,4 @@ describe("Users Endpoint", () => {
expect(responseAfter.body.users.length).toEqual(2)
})
})
})
})