Refactor globalAliases #218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #147 and #125!
The original request in #125 was to map the
Escapekey to cancellation (Ctrl+C). This was implemented by adding alias support in #147, but I agree that it's an extremely reasonable default. This PR addsescas a default keybinding.kljhescAdditionally, #147 introduced
setGlobalAliasesas a one-off function. Because there are many potential use cases for custom settings (themes / colors – see #212), this PR centralizes all global configuration in a more genericupdateSettingsfunction.As of now,
updateSettings()only accepts analiasesobject that maps custom keys to an action (up | down | left | right | space | enter | cancel). This can be expanded in the future.Warning
In order to enforce consistent, user-friendly defaults across the ecosystem,
updateSettingsdoes not support disabling Clack's default keybindings.I firmly believe that having opinions about the right usability defaults is a good thing. Flexibility for flexibility's sake is a recipe for inconsistency and user frustration.