Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip ansi for diff output #63

Merged
merged 2 commits into from
Mar 27, 2025
Merged

strip ansi for diff output #63

merged 2 commits into from
Mar 27, 2025

Conversation

gnarf
Copy link
Collaborator

@gnarf gnarf commented Mar 21, 2025

Small fix for the output of the diff - having the option to save it to a file now made the ansi colors break in the markdown

@gnarf gnarf requested a review from jugglinmike March 21, 2025 01:17
@jugglinmike
Copy link
Member

It looks like we can avoid taking another dependency for this. Would you mind doing this via configuration, instead (awkward though the API may be)?

@gnarf
Copy link
Collaborator Author

gnarf commented Mar 26, 2025

It looks like we can avoid taking another dependency for this. Would you mind doing this via configuration, instead (awkward though the API may be)?

sure... The API was very awkward, so I went with the dependency :)

@gnarf gnarf force-pushed the strip-ansi-diff branch from 593cd91 to dc20f05 Compare March 26, 2025 03:51
@jugglinmike jugglinmike merged commit 77f9898 into main Mar 27, 2025
2 checks passed
@jugglinmike jugglinmike deleted the strip-ansi-diff branch March 27, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants