feat: add --no-reload flag to disable hot reload for local commands#58
Open
cortex-assistant[bot] wants to merge 1 commit into
Open
feat: add --no-reload flag to disable hot reload for local commands#58cortex-assistant[bot] wants to merge 1 commit into
cortex-assistant[bot] wants to merge 1 commit into
Conversation
|
Hey there, I'm looking forward to this, do you know if this mergable into the main SAM repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57.
Adds a new
--no-reloadflag tosam local start-apiandsam local start-lambdacommands that disables the file watcher/hot reload when used with--warm-containers. This addresses the significant performance issue on Windows where Microsoft Defender scanning causes the watchdog-based file observer to take 2-5 minutes to initialize.Changes:
--no-reloadCLI option inoptions.pystart-apiandstart-lambdaCLI commandsInvokeContexttoWarmLambdaRuntimeLambdaFunctionObservercreation conditional inWarmLambdaRuntimevia a_NoOpObserver