Pancake and v8 bug fixes#364
Merged
Merged
Conversation
- fix exit when tapping the first 2 items in the SD menu - Partition size editor bottom labels misaligned
Fix short/long press for pancake
same fix for v8
bmorcelli
reviewed
Jul 7, 2026
bmorcelli
left a comment
bmorcelli
left a comment
Owner
There was a problem hiding this comment.
couple of changes and it is done
| // Long Press Detection | ||
| LongPressDetected = false; | ||
| #ifndef E_PAPER_DISPLAY | ||
| #if defined(PANCAKE) || defined(MARAUDERV8) |
Owner
There was a problem hiding this comment.
This issue will happen to all devices sharing Touch with TFT, that are under DONT_USE_INPUT_TASK flag.. so you can generalize it usinf this flag.
when this flag is used, it runs the InputHandler function every 5 runs of check(...), it doesn't happen when using inputHandlingTask.. which runs almost every 10ms...
Contributor
Author
There was a problem hiding this comment.
So I just replace this line with
#if defined(HAS_TOUCH) && defined(DONT_USE_INPUT_TASK) && !defined(E_PAPER_DISPLAY)
Apply fix to all where needed
Spread the three hints into left/centre/right columns so they line up cleanly across the width (matches the touch footer layout).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pancake bug fixes
Marauder V8 bug fixes
I believe the Marauder v6.1 and other similar boards require this fix too, but I can't test them, so I left it only for the ones I could verify.
Could simply change (in sd_functions.cpp line #325)
#if defined(PANCAKE) || defined(MARAUDERV8)
to
#if defined(HAS_TOUCH) && defined(DONT_USE_INPUT_TASK) && !defined(E_PAPER_DISPLAY)
to include them.