manager: add insets support to webui #1340
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync tiann/KernelSU#2952, tiann/KernelSU#3083 add insets support to WebUI, no change are required for existing WebUI module. Co-Authored-By: Der_Googler <[email protected]> Co-Authored-By: Light_summer <[email protected]> Signed-off-by: KOWX712 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds window insets support to the WebUI feature, allowing web modules to adapt their layout to device screen safe areas (notches, status bars, and navigation bars). This is synchronized from KernelSU issues #2952 and #3083.
Key changes:
- Introduced an
Insetsdata class that generates CSS variables for safe area handling - Added JavaScript interface method
enableInsets()to toggle insets behavior dynamically - Refactored WebView initialization to support both traditional padding-based layout and CSS variable-based insets
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| app/src/main/java/me/bmax/apatch/ui/webui/Insets.kt | New data class that encapsulates inset values and generates CSS custom properties for web content |
| app/src/main/java/me/bmax/apatch/ui/webui/SuFilePathHandler.java | Added interfaces for insets supplier and listener, plus CSS file intercept for serving insets dynamically |
| app/src/main/java/me/bmax/apatch/ui/webui/WebViewInterface.kt | Added enableInsets() JavaScript interface method to toggle insets mode from web code |
| app/src/main/java/me/bmax/apatch/ui/WebUIActivity.kt | Major refactoring: moved WebView into FrameLayout container, implemented dynamic insets handling, and added suspension logic for insets initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/main/java/me/bmax/apatch/ui/webui/SuFilePathHandler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add insets support to WebUI, no change are required for existing WebUI module.