-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenSuSE improvements #18
Open
neilmunday
wants to merge
7
commits into
bluebanquise:master
Choose a base branch
from
neilmunday:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mparisons to handle OS distributions with spaces in their names
Dear @neilmunday Thanks a lot for this PR. I will let it on hold a bit, I am near to finish the major update of this repo. I will then merge this PR 🙂 Hope you understand. |
@oxedions sure, no worries :-) |
@neilmunday sorry for the delay. I merged the new factory. I will integrate your changes asap now 😊 |
@oxedions no worries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitignore
fileis_opensuse
variable to correct where files are installed etc.$distribution
variable inauto_builder.sh
is encapsulated in double quotes as OpenSuSE is detected with spaces in the name. Therefore without the encapsulation, a BASH error results.