Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connection name in error callback message #52

Merged
merged 3 commits into from
Dec 8, 2024
Merged

Add connection name in error callback message #52

merged 3 commits into from
Dec 8, 2024

Conversation

ThisIsNSH
Copy link
Contributor

Problem statement

  • In a multi connection setup, error callback from connection.close does not help in distinguishing the connection

Proposed changes

  • Add connection name in error callback message

Remaining work

  • Unit Tests
  • Integration Tests
  • Documentation

@sgalichkin
Copy link

👍

sgalichkin
sgalichkin approved these changes Dec 4, 2024
View reviewed changes
Copy link

@sgalichkin sgalichkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/rmq/rmqamqp/rmqamqp_connection.cpp Outdated Show resolved Hide resolved
willhoy
willhoy previously approved these changes Dec 4, 2024
View reviewed changes
@ThisIsNSH
Update Makefile
8639614 
Signed-off-by: Nishant <[email protected]>
@willhoy willhoy merged commit 38b5fd8 into bloomberg:main Dec 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willhoy willhoy willhoy approved these changes

@sgalichkin sgalichkin Awaiting requested review from sgalichkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThisIsNSH @sgalichkin @willhoy