Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the onSuccess() callback #44

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Pasick
Copy link

@Pasick Pasick commented Jun 17, 2024

Problem statement

Current implementation of rmqcpp library only provides a callback when the connection is broken. There is no callback which allows to detect when connection is restored to provide a more flexible way to monitor the connection state.

Proposed changes

The onSuccess() callback is raised on connection restore.

Remaining work

  • Unit Tests
  • Integration Tests
  • Documentation

Copy link
Contributor

@willhoy willhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@willhoy
Copy link
Contributor

willhoy commented Jul 17, 2024

can you please sign your commit and we can get this merged thanks?

Learn more about signing commits.

@willhoy
Copy link
Contributor

willhoy commented Nov 25, 2024

@Pasick, this is still waiting on [4b57d4a] (4b57d4a) to be signed

something like this should help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants