fix: release workflow improvements#38
Merged
alecthomas merged 2 commits intoJun 11, 2026
Merged
Conversation
alecthomas
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related changes to
release.yml, in two commits.1. Build-provenance attestation +
SHA256SUMSactions/attest-build-provenance@v2(digest-pinned) in the build job, emitting a SLSA v1.0 provenance statement signed by Sigstore via the runner's OIDC identity. Downstream installers can verify withgh attestation verify --owner block --repo lefthookmerge <file>.SHA256SUMSover the.bz2artifacts and attaches it to the release.permissionsblock to the build job (contents: read,id-token: write,attestations: write) — setting any permission switches the job to a strict allowlist, socontents: readis restated to keep checkout working.2. Tag-trigger glob + quoting
v[0-9]+.[0-9]+.[0-9]+is a glob, not a regex — the literal+made it match only the tagv+.+.+. Releases fire today only becauseworkflow_dispatchis also enabled. Replaced withv[0-9]*.[0-9]*.[0-9]*.github.ref_namethrough aTAGenv var and uses quoted"$TAG"ingh release create, so the value is always a single argument regardless of content.Happy to split into two PRs if you'd rather review them separately.