fix: migrate off archived serde_yaml; cap config size at 1 MiB#36
Merged
alecthomas merged 1 commit intoJun 11, 2026
Merged
Conversation
alecthomas
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
serde_yamlis the YAML parser facing untrusted input (repo configs) on every git invocation, and it's archived/deprecated upstream — future advisories won't be patched.The Fix
serde_yaml 0.9.34for the maintainedserde_yaml_ng 0.10.0, aliased back to theserde_yamlpackage name so no call sites change.Testing
cargo test(147 passing, including the size-cap path).