[feat] MCP prompts #639
Closed
[feat] MCP prompts #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baxen
approved these changes
Jan 17, 2025
| let client = capabilities | ||
| .get_system(system) | ||
| .await | ||
| .unwrap_or_else(|| panic!("System not found: {}", system)); |
There was a problem hiding this comment.
I think we should return an Err (SystemError::UnknownSystem) here instead of panicing?
| async fn passthrough(&self, _system: &str, _request: Value) -> SystemResult<Value> { | ||
| // TODO implement | ||
| Ok(Value::Null) | ||
| async fn passthrough(&self, system: &str, method: &str, params: Value) -> SystemResult<Value> { |
There was a problem hiding this comment.
meganit: maybe implement self.capabilities.passthrough helper - i think this code would be the same throughout
wendytang
reviewed
Jan 18, 2025
| @@ -314,4 +314,10 @@ impl Capabilities { | |||
|
|
|||
| result | |||
| } | |||
|
|
|||
| /// Retrieve a client by name, if it exists | |||
| pub async fn get_system(&self, system: &str) -> Option<Arc<Mutex<Box<dyn McpClientTrait>>>> { | |||
There was a problem hiding this comment.
nit: for clarity get_client to match get_client_for_tool?
wendytang
reviewed
Jan 18, 2025
|
ported over here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement get_prompt and list_prompts per MCP: https://spec.modelcontextprotocol.io/specification/2024-11-05/server/prompts/