feat: Support mcp setup on CLI #636
Conversation
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
| let selected = | ||
| cliclack::multiselect("enable systems: (use \"space\" to toggle and \"enter\" to submit)") | ||
| .items( | ||
| &system_status | ||
| .iter() | ||
| .map(|(name, _)| (name, name.as_str(), "")) | ||
| .collect::<Vec<_>>(), | ||
| ) | ||
| .initial_values(enabled_systems) | ||
| .interact()?; |
There was a problem hiding this comment.
I can't disable all my systems, if thats intentional we should add at least one must be enabled. "Input required" wasn't clear to me.
There was a problem hiding this comment.
fixing! just missed an option on the multiselect
| let config = Config::load().unwrap_or_else(|_| { | ||
| println!("No configuration found. Please run 'goose configure' first."); | ||
| process::exit(1); | ||
| }); |
There was a problem hiding this comment.
Do we want to distinguish between "no config" vs "invalid" config?
I made my config file invalid yaml and just got
No configuration found. Please run 'goose configure' first.
| )] | ||
| profile: Option<String>, | ||
| model: Option<String>, |
There was a problem hiding this comment.
should we remove the --provider and --model options? currently, if someone runs:
./target/debug/goose configure --provider openai --model gpt-4o
./target/debug/goose session
No configuration found. Please run 'goose configure' first.There was a problem hiding this comment.
Oh good point. I do want to support these options for e.g. automations, but i need to remove the check for config if they are set
There was a problem hiding this comment.
I will have to revisit this though in a followup PR where we introduce system management for automations, so right now the file is still required for systems
This includes a refactor of the config and configuration CLI to support the systems, and because they make config more complex we simplified other aspects like removing profiles. Instead hopefully the commands make it easy to change things on the fly. There are now environment and CLI overrides for everything but systems. We can implement those in a followup pr (e.g. a list of which named systems we should run with)
baxen
force-pushed
the
baxen/config-updates
branch
from
0afde15 to
e90f66d
Compare
This includes a refactor of the config and configuration CLI to support the systems, and because they make config more complex we simplified other aspects like removing profiles. Instead hopefully the commands make it easy to change things on the fly.
There are now environment and CLI overrides for everything but systems. We can implement those in a followup pr (e.g. a list of which named systems we should run with)