Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove bundle.py, and reference to it #632

Merged
merged 2 commits into from
Jan 16, 2025
Merged

ci: remove bundle.py, and reference to it #632

merged 2 commits into from
Jan 16, 2025

Conversation

kalvinnchau
Copy link
Collaborator

Removes the bundle.py file and any references to it

@kalvinnchau kalvinnchau marked this pull request as ready for review January 16, 2025 19:00
@github-actions GitHub Actions
Copy link

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

salman1993
salman1993 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@salman1993 salman1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good but lets wait for @michaelneale to approve

michaelneale
michaelneale reviewed Jan 16, 2025
View reviewed changes
ui/desktop/package.json Outdated
@@ -10,7 +10,7 @@
"start:test-error": "GOOSE_TEST_ERROR=true electron-forge start",
"package": "electron-forge package",
"make": "electron-forge make",
"bundle:preconfigured": "./bundle.py && npm run make && echo 'resetting main' && git checkout src/main.ts && cd out/Goose-darwin-arm64 && ditto -c -k --sequesterRsrc --keepParent Goose.app Goose.zip",
"bundle:preconfigured": "npm run make && echo 'resetting main' && git checkout src/main.ts && cd out/Goose-darwin-arm64 && ditto -c -k --sequesterRsrc --keepParent Goose.app Goose.zip",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without that bundle script we don't need this anymore do this? as in it won't do anything different to the default?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, will remove that

@github-actions GitHub Actions
Copy link

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@kalvinnchau kalvinnchau merged commit 3061478 into v1.0 Jan 16, 2025
6 checks passed
@kalvinnchau kalvinnchau deleted the kalvin/remove-bundle branch January 16, 2025 23:47
michaelneale added a commit that referenced this pull request Jan 17, 2025
@michaelneale
Merge branch 'v1.0' into micn/hermitize-mcp
7b0d99c 
* v1.0:
  ci: remove bundle.py, and reference to it (#632)
  feat: enable prompt cache for anthropic  (#631)
  feat: memory server (#601)
acekyd pushed a commit that referenced this pull request Jan 21, 2025
@kalvinnchau @acekyd
ci: remove bundle.py, and reference to it (#632)
e931318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelneale michaelneale michaelneale left review comments

@salman1993 salman1993 salman1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalvinnchau @michaelneale @salman1993