Repository navigation
Conversation
Signed-off-by: Ammanuel Getenet <ammanuelamsal@gmail.com>
🔐 Codex Security Review
|
ammanviii
marked this pull request as ready for review
October 28, 2026 15:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release/profile mobile builds currently reject a non-default HTTPS gateway port, such as
https://push.example:8444. This prevents separately signed personal builds from using a valid private HTTPS gateway on a non-default port, even though native gateway-origin canonicalization already preserves it.Permit explicit ports in the existing 1..65535 range. Keep HTTPS mandatory for release/profile builds and preserve credential, path, query, and fragment rejection. Update the build error and mobile documentation. No TLS, App Attest, transcript audience, relay authentication, or push protocol behavior changes.
Related issue
Related context: #5206 (self-hosted relay operators). This does not enable the public App Store application's push gateway or address its enrollment availability. No matching existing port-policy PR was found in the duplicate search.
Testing
just mobile-install mobile-check mobile-testpassed. Configured suite: 3735 passed, 16 skipped. Unconfigured-build suite: 4 passed. Gateway-recipe suite: 9 passed.swift test --package-path mobile/ios/BuzzPushKit: 97 XCTest and 65 Swift Testing tests passed.Verification refresh — October 27
Exact PR head:
ab31b7a6f15a2b7b2f5e41ba56829c361728f3d5; working tree clean.just mobile-check mobile-test: passed. Analysis reports no issues; configured suite 3735 passed / 16 skipped; unconfigured suite 4 passed.CHECK_FILE_SIZES_BASE=1a54eec3dbfd049f98dfca678c3060c5c3a8f0a1 just file-size-check: passed against the contribution base.Server-side delivery verification — October 28
Read-only checks of the personal relay and push gateway, using the installed build 2026102101 with the explicit HTTPS gateway port:
deliveredon its first attempt, matching the phone's current endpoint and lease generation.acceptedoutcomes. These cumulative counters corroborate successful server-to-Apple handoff; they are not per-device delivery receipts.Human iPhone verification — October 28
ab31b7a6f15a2b7b2f5e41ba56829c361728f3d5.buzz-review-completed
Evidence
Merge Danger
Door: two-way. Reverting restores the prior build restriction.
Blast Radius: mobile-builds. This expands accepted build configuration only; it does not select a gateway, enable push on a relay, or change runtime verification.