fix(pair-relay): bind to :18765 by default instead of :5000 - #7021
Open
Chessing234 wants to merge 3 commits into
Open
fix(pair-relay): bind to :18765 by default instead of :5000#7021Chessing234 wants to merge 3 commits into
Chessing234 wants to merge 3 commits into
Conversation
macOS AirPlay Receiver owns port 5000, so a local pair-relay never binds and clients get a misleading empty 403 from ControlCenter. Signed-off-by: Taksh <takshkothari09@gmail.com>
Keep the chart and README aligned with the new local default so ingress examples do not send traffic at AirPlay's port. Signed-off-by: Taksh <takshkothari09@gmail.com>
Signed-off-by: Taksh <takshkothari09@gmail.com>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUZZ_PAIR_RELAY_BIND_ADDRis now127.0.0.1:18765instead of:5000.Fixes #7008.
Test plan
./bin/cargo test -p buzz-pair-relay --lib