Skip to content
This repository was archived by the owner on Mar 7, 2026. It is now read-only.

stlink: replace odr register for the isol variant#1746

Merged
dragonmux merged 1 commit intoblackmagic-debug:mainfrom
HrMitrev:odr-to-bsrr
Jan 25, 2024
Merged

stlink: replace odr register for the isol variant#1746
dragonmux merged 1 commit intoblackmagic-debug:mainfrom
HrMitrev:odr-to-bsrr

Conversation

@HrMitrev
Copy link
Copy Markdown
Contributor

@HrMitrev HrMitrev commented Jan 24, 2024

Detailed description

This is a follow up to PR1720 where I used the Output Data Register of the GPIO peripheral, causing read modify write. Now we use BSRR and BRR which only require a single write. I benchmarked the speed(when flashing 128kb firmware file) of the probe after this patch and it seems to be very similar, however the code size is reduced by a few bytes and as we know - every byte counts

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

N/A

Copy link
Copy Markdown
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only one review item we have - with it addressed, this LGTM and can be merged.

@dragonmux dragonmux added this to the v2.0 release milestone Jan 25, 2024
@dragonmux dragonmux added Enhancement General project improvement Foreign Host Board Non Native hardware to runing Black Magic firmware on labels Jan 25, 2024
Copy link
Copy Markdown
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging - thank you for the contribution!

@dragonmux dragonmux merged commit c0bf9e4 into blackmagic-debug:main Jan 25, 2024
@HrMitrev HrMitrev deleted the odr-to-bsrr branch January 25, 2024 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Enhancement General project improvement Foreign Host Board Non Native hardware to runing Black Magic firmware on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants