This repository was archived by the owner on Mar 7, 2026. It is now read-only.
stlink: replace odr register for the isol variant#1746
Merged
dragonmux merged 1 commit intoblackmagic-debug:mainfrom Jan 25, 2024
Merged
stlink: replace odr register for the isol variant#1746dragonmux merged 1 commit intoblackmagic-debug:mainfrom
dragonmux merged 1 commit intoblackmagic-debug:mainfrom
Conversation
dragonmux
reviewed
Jan 25, 2024
Member
dragonmux
left a comment
There was a problem hiding this comment.
There's only one review item we have - with it addressed, this LGTM and can be merged.
dragonmux
approved these changes
Jan 25, 2024
Member
dragonmux
left a comment
There was a problem hiding this comment.
LGTM, merging - thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
This is a follow up to PR1720 where I used the Output Data Register of the GPIO peripheral, causing read modify write. Now we use BSRR and BRR which only require a single write. I benchmarked the speed(when flashing 128kb firmware file) of the probe after this patch and it seems to be very similar, however the code size is reduced by a few bytes and as we know - every byte counts
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues
N/A