Add blocking-based poll_oneoff to support clock_nanosleep
#88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a blocking-based `poll_oneoff` implementation to support `clock_nanosleep` in wasi-libc. This implementation is very simple and only supports a single subscription for now but is enough for `clock_nanosleep` to work.
kateinoigakukun
force-pushed
the
katei/add-poll-oneoff
branch
from
598a66d to
ccc5dce
Compare
bjorn3
reviewed
Feb 16, 2025
| // TODO: For now, we only support a single subscription just to be enough for wasi-libc's | ||
| // clock_nanosleep. | ||
| if (nsubscriptions > 1) { | ||
| return wasi.ERRNO_NOTSUP; |
There was a problem hiding this comment.
Maybe add a debug.log() for each ERRNO_NOTSUP error explaining what the error is?
bjorn3
requested changes
Feb 16, 2025
src/wasi.ts
Outdated
| } | ||
| const clockid = buffer.getUint32(in_ptr + 16, true); | ||
| const timeout = buffer.getBigUint64(in_ptr + 24, true); | ||
| const flags = buffer.getUint16(in_ptr + 36, true); |
There was a problem hiding this comment.
Maybe add parsing for the subscription type to wasi_defs.ts? You can use the Iovec class as inspiration for the interface to expose.
| : getNow() + timeout; | ||
| while (endTime > getNow()) { | ||
| // block until the timeout is reached | ||
| } |
There was a problem hiding this comment.
Not an ideal solution as this will block user interaction if it runs on the main thread and unnecessarily uses the cpu which especially on mobile devices is bad, but I guess there isn't really a better way.
There was a problem hiding this comment.
Yeah, JSPI could be a mitigation but I think it's too early to use it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a blocking-based
poll_oneoffimplementation to supportclock_nanosleepin wasi-libc. This implementation is very simple and only supports a single subscription for now but is enough forclock_nanosleepto work.