[PC-42433] Handle Seat Expansion for Staged Users

[sven-bitwarden]

🎟️ Tracking

PM-42433

📔 Objective

Staged users are pre-existing organization users that do not occupy a seat for billing purposes - it is therefore necessary to do seat-count validation before promoting them in all scenarios.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the seat-reservation fix in AcceptOrganizationInviteLinkCommand plus its unit tests. The premise holds: Organization_ReadOccupiedSeatCountByOrganizationId counts only statuses 0/1/2 and the EF equivalent filters to Invited/Accepted/Confirmed, so a Staged row occupies no seat and promoting it to Accepted genuinely consumes capacity — the new reservation is correct. The Invited branch is rightly left alone (those rows already count), and since the validator rejects Revoked/Accepted/Confirmed up front, Invited and Staged are the only statuses reaching AcceptExistingOrgUserAsync; GetByOrganizationEmailAsync applies no status filter and staged rows always have UserId = null, so the email-lookup path is the one that surfaces them. The ReserveSeatAsync extraction is behavior-preserving for CreateNewMembershipAsync and runs before any persistence or emergency-access deletion, and the tests cover seats-available, autoscale, no-seats, and billing-failure paths plus a guard test proving the Invited path does not over-reserve.

Code Review Details

No findings.

PR Metadata Assessment

• ❓ : Title says PC-42433 while the tracking link is PM-42433 — likely a typo that will break Jira linking.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.21%. Comparing base (aebb9c4) to head (d65c4a5).

❗ There is a different number of reports uploaded between BASE (aebb9c4) and HEAD (d65c4a5). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (aebb9c4)	HEAD (d65c4a5)
	2	1

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8251      +/-   ##
==========================================
- Coverage   68.88%   63.21%   -5.68%     
==========================================
  Files        2410     2410              
  Lines      104442   104452      +10     
  Branches     9457     9459       +2     
==========================================
- Hits        71946    66028    -5918     
- Misses      30115    36165    +6050     
+ Partials     2381     2259     -122     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[eliykat]

LGTM as a minimal fix for this logic. It might benefit from @r-tome 's eyes as well as he wrote this originally.

[r-tome]

Looks good to me! Nice work