Skip to content

[PM-42203] Add feature flag enable-basic-auth-response - #8248

Merged
jprusik merged 2 commits into
mainfrom
pm-42203
Aug 25, 2026
Merged

[PM-42203] Add feature flag enable-basic-auth-response#8248
jprusik merged 2 commits into
mainfrom
pm-42203

Conversation

@jprusik

@jprusik jprusik commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-42203

📔 Objective

Add feature flag enable-basic-auth-response

See corresponding clients work at bitwarden/clients#22612

@jprusik jprusik self-assigned this Aug 24, 2026
@jprusik jprusik added feature-flag ai-review-vnext Request a Claude code review using the vNext workflow labels Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a single feature flag constant, EnableBasicAuthResponse (enable-basic-auth-response), to the Autofill Team section of src/Core/Constants.cs. The constant name, kebab-case value, and placement match neighboring flags such as EnableAutofillTriage and LitInlineMenuComponents, and the key is unique across the repository. The flag is not yet referenced by server code, which is consistent with the linked clients-side work described in the PR body. No security, correctness, performance, or breaking-change concerns were identified.

Code Review Details

No findings.

@jprusik
jprusik requested review from a team and blackwood August 24, 2026 18:43
@jprusik

jprusik commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Test failures are pre-existing / from main (not introduced by these changes)

@jprusik
jprusik requested a review from bensbits91 August 24, 2026 18:47
@jprusik
jprusik removed the request for review from bensbits91 August 25, 2026 18:09
@jprusik jprusik added the t:feature Change Type - Feature Development label Aug 25, 2026
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.19%. Comparing base (da39ab7) to head (58eb10d).

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #8248       +/-   ##
=========================================
+ Coverage      0   63.19%   +63.19%     
=========================================
  Files         0     2409     +2409     
  Lines         0   104393   +104393     
  Branches      0     9453     +9453     
=========================================
+ Hits          0    65973    +65973     
- Misses        0    36162    +36162     
- Partials      0     2258     +2258     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jprusik
jprusik merged commit 13faf3e into main Aug 25, 2026
46 of 47 checks passed
@jprusik
jprusik deleted the pm-42203 branch August 25, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow feature-flag t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants