Skip to content

Conversation

@eligrubb
Copy link
Member

@eligrubb eligrubb commented Jan 5, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27278

📔 Objective

Deprecating V1 User Asymmetric Key information in favor of new V2 User Asymmetric Account Keys structure.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

Logo
Checkmarx One – Scan Summary & Details681c3094-cfd4-4c02-b23c-a14bb0d2d472

New Issues (2)

Checkmarx found the following issues in this Pull Request

# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM CSRF /src/Identity/Controllers/AccountsController.cs: 142
detailsMethod at line 142 of /src/Identity/Controllers/AccountsController.cs gets a parameter from a user request from model. This parameter value flow...
Attack Vector
2 MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 300
detailsMethod at line 300 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows t...
Attack Vector
Fixed Issues (7)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Billing/Controllers/VNext/AccountBillingVNextController.cs: 99
MEDIUM CSRF /src/Api/Billing/Controllers/VNext/AccountBillingVNextController.cs: 98
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1170
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1060
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 431
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1519
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1395

@eligrubb eligrubb force-pushed the km/pm-27278/register-password-based-account-v2 branch from aa11c99 to 64585b7 Compare January 6, 2026 22:08
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 0% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.32%. Comparing base (b5dadcd) to head (64585b7).

Files with missing lines Patch % Lines
...Api/Request/Accounts/RegisterFinishRequestModel.cs 0.00% 56 Missing ⚠️
...frastructure.Dapper/Repositories/UserRepository.cs 0.00% 24 Missing ⚠️
...ure.EntityFramework/Repositories/UserRepository.cs 0.00% 22 Missing ⚠️
src/Core/Services/Implementations/UserService.cs 0.00% 12 Missing ⚠️
...re/KeyManagement/Models/Data/RegisterFinishData.cs 0.00% 6 Missing ⚠️
...egistration/Implementations/RegisterUserCommand.cs 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b5dadcd) and HEAD (64585b7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b5dadcd) HEAD (64585b7)
2 1
Additional details and impacted files
@@                                Coverage Diff                                 @@
##           auth/pm-27084/register-accepts-new-data-types    #6798       +/-   ##
==================================================================================
- Coverage                                          58.85%   13.32%   -45.53%     
==================================================================================
  Files                                               1927     1165      -762     
  Lines                                              85627    50940    -34687     
  Branches                                            7677     4005     -3672     
==================================================================================
- Hits                                               50396     6788    -43608     
- Misses                                             33346    44028    +10682     
+ Partials                                            1885      124     -1761     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants